Skip to content

feat(reports): leftover-map singular values on leftover-axis report badges (v2.79.0) - #862

Open
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-singular-v2780from
feat/leftover-map-axis-singular-v2790
Open

feat(reports): leftover-map singular values on leftover-axis report badges (v2.79.0)#862
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-singular-v2780from
feat/leftover-map-axis-singular-v2790

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • leftoverMapAxisBadge.test.ts reads 1.84/0.86, names rank-0 0, omits NaN/Infinity/null/negative, does not invent σ from leftover-map axis share, keeps leftover-axis badge copy distinct from hyphen graphic σ, comparison graphic σ, and share-only leftover-axis copy
  • leftoverMapPlotAxisSingular.test.ts comparison graphic σ stays distinct from leftover-axis badge σ {value} {share}%
  • App.test.tsx leftover-axis report badges name leftover axis 1 σ 1.84 82% / leftover axis 2 σ 0.86 18%; grouping comparison does not gain leftover-axis badge copy; comparison graphic keeps leftover map comparison graphic leftover-map axis σ
  • LeftoverMapPlot.test.tsx comparison graphic still omits leftover axis 1 σ 1.84 82%
  • i18n.test.ts required keys for leftover-axis badge σ + share in ko/zh/ja/vi
  • frontend oxlint on changed files: 0 warnings, 0 errors
  • frontend vitest: 569 tests passed (App.test.tsx, LeftoverMapPlot.test.tsx, LeftoverPairList.test.tsx, i18n.test.ts, leftover-map helpers)
  • CI Full test suite and Frontend lint, test, build on this exact head
  • After make seed, leftover-axis report badges name leftover-map singular values; click opens that post.

Evidence boundary

Authenticated PostgreSQL API and k6 runtime acceptance are not claimed. No real records or credentials. Synthetic fixtures only.

Independent approval is required. No self-approval, admin bypass, or force push.

Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.

Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.


Devin Review

…adges (v2.79.0)

Caption persisted leftover-map singular values σ_k on leftover-axis report badges from already-named leftover-map axes (ADR 0322). Rank-0 unused axes still name σ 0.00. Do not invent σ from leftover-map axis share. Synthetic fixtures only.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 17cfca97-269b-4f40-beb4-4080cf434f2f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact head f24b664ce88bb2b3898fcaa0fd0ee7f69c5e12f7 stacked on #861 @ 3aac452. Copilot/Devin review is not independent APPROVE. Leave this PR open. Do not squash-merge. Do not self-approve. Issues #79 and #87 stay open.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant