feat(reports): leftover-map axis share on leftover-map comparison leftover-axis ticks independently of leftover-map singular values (v2.90.0) - #874
Conversation
…tover-axis ticks independently of leftover-map singular values (v2.90.0) Caption leftover-map comparison leftover-axis ticks with persisted leftover-map axis share through leftoverMapCompareAxisTickBadge independently of leftover-map singular values (ADR 0333). Share and σ omit independently. Rank-0 unused axes still name leftover-map axis share 0%. Leftover-axis ticks stay σ-only. Do not invent leftover-map axis share from σ_k. Do not invent σ_k from leftover-map axis share. Never invent a leftover score or a theta. No new columns.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Leave open for independent APPROVE. Do not self-approve. Frontend lint and leftover-map + App tests are green (693 passed, oxlint 0, tsc -b). After independent review, retarget onto leftover-coordinates rather than squash-merging onto the leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Cycle 2026-08-31 14:40 KST: leftover-map comparison leftover-axis tick leftover-map axis share (ADR 0333 / v2.90.0) is complete at ba58c21. Frontend lint SUCCESS, Full test suite SUCCESS, Devin COMMENT only. Leave open for independent APPROVE. Do not self-approve. Do not squash-merge onto the leftover base. After independent review, retarget onto leftover-coordinates rather than merging here. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. Next stacked increment: leftover-axis ticks leftover-map axis share independently of leftover-map singular values as leftoverMapAxisTickBadge (ADR 0334 / v2.91.0). |
|
cycle-write-probe 2026-08-31T06:16Z: independent review only; no self-approve. Next buyer gap after leftover-map axis share (v2.90.0). |
|
Cycle 2026-08-31 15:24 KST: writes work (ghu_ seonghobae, admin/push). This PR #874 remains MERGEABLE at ba58c21 (v2.90.0 / ADR 0333). Frontend lint SUCCESS, Full test suite SUCCESS. Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge onto the leftover base. Next increment is leftover-axis ticks leftover-map axis share independently of leftover-map singular values as leftoverMapAxisTickBadge (ADR 0334 / v2.91.0) on feat/leftover-map-axis-tick-share-badge-v2910 stacked onto this head. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. |
|
Cycle note (2026-08-31 15:24 KST): GitHub writes work ( |
|
Leave #874 open for independent APPROVE. Devin Review COMMENTED is not APPROVE. Do not squash-merge. Do not self-approve. After independent review, retarget leftover-map stack onto leftover-coordinates ( |
|
Leave #874 open for independent APPROVE. Stacked next increment is leftover-axis ticks leftover-map axis share independently of leftover-map singular values as leftoverMapAxisTickBadge (ADR 0334 / v2.91.0) on |
|
Cycle 2026-08-31 15:53 KST: #875 leftover-axis ticks leftover-map axis share independently of leftover-map singular values (ADR 0334 / v2.91.0) is stacked onto this exact head ba58c21. This PR #874 remains MERGEABLE (v2.90.0 / ADR 0333). Devin COMMENT is not independent APPROVE. Leave open for independent APPROVE. Do not self-approve. Do not squash-merge onto the leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. |
1 participant
Summary
make seed, leftover-map comparison leftover-axis ticks name persisted leftover-map axis share when leftoverMapCompareAxisTickBadge returns a usable leftover-axis tick leftover-map axis share caption even when leftover-map singular values are omitted; click a leftover pair opens that post.leftover map comparison leftover axis {k} tick {value} {share}%when leftover-map axis share is finite andσ_komits, andleftover map comparison leftover axis {k} tick {value} σ {singular} {share}%when both are finite so they stay distinct from leftover-map graphic leftover-map axis ticksleftover-map axis {k} tick {value} σ {singular} {share}%(ADR 0332), from leftover-map comparison graphic leftover-map axis ticksleftover map comparison graphic leftover-map axis {k} tick {value} σ {singular} {share}%(ADR 0331), from leftover-axisleftover axis {k} {share}%(ADR 0325), from comparison leftover-axisleftover map comparison leftover axis {k} {share}%(ADR 0323), from leftover-axis ticksleftover axis {k} tick {value} σ {singular}(ADR 0330), and from leftover-map comparison leftover-axis ticksleftover map comparison leftover axis {k} tick {value} σ {singular}(ADR 0329).leftover map comparison leftover axis {k} tick {value}orleftover map comparison leftover axis {k} tick {value} σ {singular}. Rank-0 unused axes still name leftover-map axis share0%. Share and singular value omit independently. Do not invent leftover-map axis share fromσ_k. Do not inventσ_kfrom leftover-map axis share.feat/leftover-map-plot-tick-share-badge-v2890/ feat(reports): leftover-map axis share on leftover-map graphic leftover-map axis ticks independently of leftover-map singular values (v2.89.0) #873 @923bcfe). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240/ feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.Test plan
leftoverMapPlotAxisSingular.test.tsleftoverMapCompareAxisTickBadge names 82%/18% with σ 1.84/0.86, share-only when σ omits, rank-0 share 0%, omits NaN/null share independently of σ, does not invent share from σ or σ from share, leftover-axis ticks stay σ-onlyApp.test.tsxgrouping comparison leftover-axis tickleftover map comparison leftover axis 1 tick +0.50 σ 1.84 82%; leftover-axis ticks stayleftover axis 1 tick +0.50 σ 1.84i18n.test.tsko/zh/ja/vi share and singular-share leftover-axis tick keystsc -b+ vitest leftover-map + App (693 passed)