Merged
Conversation
* Send phone question bucket info to the FE * Log phone question bucket info on the FE * Add phone question to FE polling logging * Add new logged property to document capture spec * Add new value to constructor * Add new value to analytics tests * Lint fixes * Add variable to the hybrid controller * Fix lint issues * changelog: Internal, In-Person Proofing, Add phone question logging to FE * Get tests passing for polling * Revies polling started test * Use `exactly` matcher for trackEvent spy * Revise polling completed tests * Rename log variable to match the other places we log this
* Add step indicator to VerifyInfo rate limit warning page * Remove step indicator from VerifyInfo rate limit failure page changelog: User-facing Improvements, Verify Info step rate limit pages, Add step indicator to warning page and remove step indicator from rate limited page * Check for current_user in step indicator code This avoids a 500 error if error screens with step indicators are accessed from hybrid flow. * Test all session_errors routes in hybrid flow now that they all work * Set @step_indicator_steps in view specs --------- Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
* Add link to explanation of Monthly Key Metrics Report * Update recipients of Monthly Key Metrics Report changelog: Internal, Reporting, Update Monthly Key Metrics Report
* LG-11344: Prompt at most once for WebAuthn authentication changelog: Bug Fixes, Face or Touch Unlock, Prompt at most once when clicking submission button multiple times * Update removed references to button by ID
* Changelog: Bug Fixes, translations, Fixes Spanish and French translation for Sign In * French sign in translation
…#9434) When a user is rate limited on sending letters, they should not see a flash error message on the EnterPassword controller, whether they are verifying their identity by phone or by mail. changelog: User-Facing Improvements, IdV, remove obsolete too much mail message Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* changelog: User-Facing Improvements, Authentication, In person proofing waiting should allow access to account page * remove account path check * remove return * skip when in pending profile * in person spec, fix verify profile concern fix * update spec * in personccccccnucjfbjecbfguhbrdfbtvlvidgibetckftjthu * update spec * sign in user * also 2fa
* Start using new confirm_start_over_before_letter route changelog: Internal, Verify by Mail confirm start over, use new route for Verify by Mail confirm start over screen from Request Letter screen * Fix fallback_path from new before_letter template --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov>
changelog: Internal, Scripts, Fix error when querying cloudwatch with no timezone
The progressive proofer performs a resolution transaction. Address results are for address transactions. The progressive proofer should not, for this reason, ever be returning an address result. [skip changelog]
…gn-up (#9403) Add event "User registration complete" changelog: Internal, Authentication, Record event user_registration_complete
* LG-10816: Fiscal year reporting for monthly report changelog: Internal, Reporting, Add fiscal year active users count report * feedback * feedback * lint
* Add feature specs for expected skip link behavior changelog: Internal, Automated Testing, Add feature test for accessible skip link behavior * Reorganize spec helpers for skip link activation * Null assignment doesn't actually work * Blur should be a noop if already unfocused * Consistently use parantheses
* LG-11139: Add new components * LG-11139: Add checkboxes for id types, add button to exit doc auth. * LG-11139: rebase. * LG-11139: design change, sp and no sp difference. Tests for checkbox and fieldset test. Translations of nosp text. * LG-11139: component test and refactor. * LG-11139: style tweaks. * LG-11139: clean up translations. * LG-11139: remove extra entry. * LG-11139: fix tests. * LG-11139: add change log. changelog: User-Facing Improvements, IdV document capture, Add optional questions when users decide not to continue * LG-11139: there is a class that can be used. * LG-11139: support focused checkbox. * LG-11139: feature test and header level. * LG-11139: js test header fix. * LG-11139: js test header fix. * LG-11139: typos etc. * LG-11139: missing ).
changelog: Internal, Performance, Reduce size of application stylesheet
* LG-10889: Support field-specific Acuant image issue indicated by http status. * LG-11139: finish supporting other status codes. * LG-10889: translations. * LG-10889: set both sides to error if got 4xx on GetResult request, the Acuant document said it's a possible outcome. * LG-10889: fix issue when both side's error message keys are the same, the translated message turns out to be default. Seems caused by some library bug due to value collision of the hash. * LG-10889: use consistent wording. * LG-10889: i18n tasks. * LG-10889: accidental change. changelog: User-Facing Improvements, Document Capturing, Improve image related inline error messages. * LG-10889: code format.
changelog: Internal, Performance, Reduce size of application stylesheet
The change in #9375 renamed the review controller to the "enter password" controller. This commit introduced a new path, but did not start using it to support the 50/50 state when that change was deployed. This commit starts using the new path but does not remove the old ones. This is also to prevent 404s in the 50/50 state. A follow up will be needed to remove the old routes after this is deployed. [skip changelog]
**Why**: Option to increase parallelism changelog: Internal, Scripts, Add --num-threads option to query-cloudwatch
* String update. changelog: User-Facing improvements, Verify by mail, Improved wording of Welcome Back screen
* Add JavaScript naming conventions to frontend documentation changelog: Internal, Documentation, Add JavaScript naming conventions to frontend documentation * Use periods consistently * Mention React components for PascalCase Since they're typically defined as functions * Mention functions for camelCase
* Fiscal Year Start Date Calculations with Calendar Service changelog: Internal, Source code, Share fiscal year start date calculations * feedback
#9453) **Why**: To prevent dumping full stacktraces to stderr, which go to Slack changelog: Internal, Scripts, Update data-pull, action-account tasks to rescue errors
changelog: Internal, Telephony, Provide Sender ID for UK SMS
…not a remember device event (#9458) The remember device concern is used to check if the remember device interval is expired requiring a user to reauthenticate. That check is performed on these lines: https://github.com/18F/identity-idp/blob/f8ee126760a802eaa33de4d0786c120c50f16961/app/controllers/saml_idp_controller.rb#L24C29-L24C29 https://github.com/18F/identity-idp/blob/f8ee126760a802eaa33de4d0786c120c50f16961/app/controllers/openid_connect/authorization_controller.rb#L21 It looks like the `expired_for_interval?` was recently changed to return true if remember device was used at any point and is now expired (ref: https://github.com/18F/identity-idp/pull/9335/files#diff-82060fb86bc64910b8186479a6f620e6ba44b007ca059e082c468f29702cf142R56). As a result, a user is prompted to re-authenticate if their remember device session is expired, regardless of whether they have already re-authenticated. This commit reverts to the original behavior to address this bug. [skip changelog]
jmhooper
approved these changes
Oct 26, 2023
soniaconnolly
approved these changes
Oct 26, 2023
zachmargolis
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal