Skip to content

Jmax/lg 11280 update welcome back screen#9430

Merged
jmax-gsa merged 8 commits intomainfrom
jmax/LG-11280-update-welcome-back-screen
Oct 25, 2023
Merged

Jmax/lg 11280 update welcome back screen#9430
jmax-gsa merged 8 commits intomainfrom
jmax/LG-11280-update-welcome-back-screen

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Oct 23, 2023

🎫 Ticket

Link to the relevant ticket.

🛠 Summary of changes

Updated banner text on 'Welcome Back' page for verify by mail.

📜 Testing Plan

The review app is available for testing at: https://review-jmax-lg-11-9jphgg.review-app.identitysandbox.gov/

Provide a checklist of steps to confirm the changes.

  • Create a new user, enter Identity Verification, and select Verify By Mail
  • Request a letter, then log out and back in again.
  • Verify that you are on the 'Welcome back' screen, and verify the screen against the ticket
  • Edit the URL to switch to Spanish (e.g., change http://localhost:3000/verify/by_mail/enter_code to http://localhost:3000/es/verify/by_mail/enter_code
  • Verify the screen text against the Spanish translations from the ticket
  • Edit the URL to switch to French (e.g., change http://localhost:3000/es/verify/by_mail/enter_code to http://localhost:3000/fr/verify/by_mail/enter_code
  • Verify the screen text against the French translations from the ticket

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before (English):

before-en

After (English):

after-en

Before (Spanish):

before-es

After (Spanish):

after-es

Before (French):

before-fr

After (French):

after-fr

@jmax-gsa jmax-gsa marked this pull request as ready for review October 23, 2023 15:49
@jmax-gsa jmax-gsa requested review from a team and Kamal-Munshi October 23, 2023 15:49
changelog: User-Facing improvements, Verify by mail, Improved wording of Welcome Back screen
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and confirmed new message.

end

it 'shows a warning message and does not allow the user to request another letter' do
verify_spam_warning_banner_present(code_sent_at)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're moving from 'spammed' to 'rate_limited' language overall, suggest naming methods here accordingly

Suggested change
verify_spam_warning_banner_present(code_sent_at)
verify_rate_limited_warning_banner_present(code_sent_at)

@jmax-gsa jmax-gsa merged commit 7499ec7 into main Oct 25, 2023
@jmax-gsa jmax-gsa deleted the jmax/LG-11280-update-welcome-back-screen branch October 25, 2023 18:06
@mdiarra3 mdiarra3 mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants