Jmax/lg 11280 update welcome back screen#9430
Merged
Conversation
changelog: User-Facing improvements, Verify by mail, Improved wording of Welcome Back screen
soniaconnolly
approved these changes
Oct 25, 2023
Contributor
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. Tested locally and confirmed new message.
| end | ||
|
|
||
| it 'shows a warning message and does not allow the user to request another letter' do | ||
| verify_spam_warning_banner_present(code_sent_at) |
Contributor
There was a problem hiding this comment.
Since we're moving from 'spammed' to 'rate_limited' language overall, suggest naming methods here accordingly
Suggested change
| verify_spam_warning_banner_present(code_sent_at) | |
| verify_rate_limited_warning_banner_present(code_sent_at) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket.
🛠 Summary of changes
Updated banner text on 'Welcome Back' page for verify by mail.
📜 Testing Plan
The review app is available for testing at: https://review-jmax-lg-11-9jphgg.review-app.identitysandbox.gov/
Provide a checklist of steps to confirm the changes.
http://localhost:3000/verify/by_mail/enter_codetohttp://localhost:3000/es/verify/by_mail/enter_codehttp://localhost:3000/es/verify/by_mail/enter_codetohttp://localhost:3000/fr/verify/by_mail/enter_code👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before (English):
After (English):
Before (Spanish):
After (Spanish):
Before (French):
After (French):