LG-10869 Rename the review step to the enter password step#9375
Merged
LG-10869 Rename the review step to the enter password step#9375
Conversation
jmhooper
force-pushed
the
jmhooper-rename-review-step
branch
from
e05d08a to
092071e
Compare
Contributor
Maybe we could rename the methods ( |
zachmargolis
approved these changes
Oct 12, 2023
Contributor
|
Probably already on your todo list: move app/views/idv/review/* to app/views/idv/enter_password, and rename step/features/idv/steps/review_step_spec.rb |
jmhooper
force-pushed
the
jmhooper-rename-review-step
branch
5 times, most recently
from
92361f4 to
aad8f56
Compare
This commit renames the "Review" step to the "Enter password" step. This new name should hopefully better describe what is happening at this step. This commit changes the name, but leaves several places out of scope: 1. URLs: To maintain compatibility in the 50/50 state this commit introduces but does not start using URLs with the new name. Follow up commits will need to be added to use and then remove the old `/review` url. 2. Analytics event names [skip changelog]
jmhooper
force-pushed
the
jmhooper-rename-review-step
branch
from
e1d8d40 to
b6fb1b9
Compare
jmhooper
added a commit
that referenced
this pull request
Oct 25, 2023
The change in #9375 renamed the review controller to the "enter password" controller. This commit introduced a new path, but did not start using it to support the 50/50 state when that change was deployed. This commit starts using the new path but does not remove the old ones. This is also to prevent 404s in the 50/50 state. A follow up will be needed to remove the old routes after this is deployed. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Oct 25, 2023
The change in #9375 renamed the review controller to the "enter password" controller. This commit introduced a new path, but did not start using it to support the 50/50 state when that change was deployed. This commit starts using the new path but does not remove the old ones. This is also to prevent 404s in the 50/50 state. A follow up will be needed to remove the old routes after this is deployed. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames the "Review" step to the "Enter password" step. This new name should hopefully better describe what is happening at this step.
This commit changes the name, but leaves several places out of scope:
/reviewurl.