Rescue errors when running remote data-pull, action-account (LG-11359)#9453
Merged
zachmargolis merged 4 commits intomainfrom Oct 25, 2023
Merged
Rescue errors when running remote data-pull, action-account (LG-11359)#9453zachmargolis merged 4 commits intomainfrom
zachmargolis merged 4 commits intomainfrom
Conversation
**Why**: To prevent dumping full stacktraces to stderr, which go to Slack changelog: Internal, Scripts, Update data-pull, action-account tasks to rescue errors
zachmargolis
commented
Oct 25, 2023
| else | ||
| self.class.render_output(result.table, format: config.format, stdout: stdout) | ||
| end | ||
| rescue => err |
Contributor
Author
There was a problem hiding this comment.
I considered rescuing Exception here because we really don't want things escaping, and it's hard to know what will be thrown... but in the meantime sticking with StandardError (as-is) seems fine.
olatifflexion
approved these changes
Oct 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11359
🛠 Summary of changes
Fixes scripts so that we don't log stacktraces like this