Conversation
… was a remember device event The remember device concern is used to check if the remember device interval is expired requiring a user to reauthenticate. That check is performed on these lines: https://github.com/18F/identity-idp/blob/f8ee126760a802eaa33de4d0786c120c50f16961/app/controllers/saml_idp_controller.rb#L24C29-L24C29 https://github.com/18F/identity-idp/blob/f8ee126760a802eaa33de4d0786c120c50f16961/app/controllers/openid_connect/authorization_controller.rb#L21 It looks like the `expired_for_interval?` was recently changed to return true if remember device was used at any point and is now expired (ref: https://github.com/18F/identity-idp/pull/9335/files#diff-82060fb86bc64910b8186479a6f620e6ba44b007ca059e082c468f29702cf142R56). As a result, a user is prompted to re-authenticate if their remember device session is expired, regardless of whether they have already re-authenticated. This commit reverts to the original behavior to address this bug. [skip changelog]
aduth
approved these changes
Oct 26, 2023
jmhooper
deleted the
jmhooper-return-false-expired-for-interval-for-other-auth-method
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remember device concern is used to check if the remember device interval is expired requiring a user to re-authenticate. That check is performed on these lines:
identity-idp/app/controllers/saml_idp_controller.rb
Line 24 in f8ee126
identity-idp/app/controllers/openid_connect/authorization_controller.rb
Line 21 in f8ee126
It looks like the
expired_for_interval?was recently changed to return true if remember device was used at any point and is now expired (ref: https://github.com/18F/identity-idp/pull/9335/files#diff-82060fb86bc64910b8186479a6f620e6ba44b007ca059e082c468f29702cf142R56). As a result, a user is prompted to re-authenticate if their remember device session is expired, regardless of whether they have already re-authenticated.This commit reverts to the original behavior to address this bug.