Stop returning an AddressResult from the progressive proofer#9439
Merged
Stop returning an AddressResult from the progressive proofer#9439
Conversation
The progressive proofer performs a resolution transaction. Address results are for address transactions. The progressive proofer should not, for this reason, ever be returning an address result. [skip changelog]
mitchellhenke
approved these changes
Oct 24, 2023
svalexander
approved these changes
Oct 24, 2023
Contributor
svalexander
left a comment
svalexander
left a comment
There was a problem hiding this comment.
This makes sense. We'll work on adding test coverage separately.
jmhooper
added a commit
that referenced
this pull request
Oct 24, 2023
The progressive proofer performs a resolution transaction. Address results are for address transactions. The progressive proofer should not, for this reason, ever be returning an address result. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progressive proofer performs a resolution transaction. Address results are for address transactions. The progressive proofer should not, for this reason, ever be returning an address result.