Skip to content

LG-10996 Fix Spanish and French translation for Sign In#9429

Merged
kevinsmaster5 merged 2 commits intomainfrom
kmas-lg-10996-fix-spanish-french-sign-in
Oct 23, 2023
Merged

LG-10996 Fix Spanish and French translation for Sign In#9429
kevinsmaster5 merged 2 commits intomainfrom
kmas-lg-10996-fix-spanish-french-sign-in

Conversation

@kevinsmaster5
Copy link
Contributor

🎫 Ticket

LG-10996

🛠 Summary of changes

Change the localization token from links.next to links.sign_in and update all instances of that token.
Revise Spanish and French translation. Found in identity-site code.

📜 Testing Plan

  • Visit http://localhost:3000
  • Find the language switching drop-up in the footer and change to Spanish / French
  • Sign In no longer translated to "Next" in the respective language.

@kevinsmaster5 kevinsmaster5 marked this pull request as ready for review October 23, 2023 13:36
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify where specifically you got these labels from? I discovered a few different variations in identity-site, and I expect there may be some which are a little better contextually used as a verb.

go_back: Regresa
help: Ayuda
new_tab: (abrir nueva pestaña)
next: Siguiente
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to include it in scope here, but I discovered that we're referencing these labels in some places in support articles, so I assume we'd want to keep those in sync with the actual implementation. Might be a question to bring back to the team to discuss how we'd want to address this.

Example: https://github.com/18F/identity-site/blob/e6f6ada/content/_help/manage-your-account/change-your-phone-number._es.md#L17

@aduth
Copy link
Contributor

aduth commented Oct 23, 2023

Could you clarify where specifically you got these labels from? I discovered a few different variations in identity-site, and I expect there may be some which are a little better contextually used as a verb.

Example: "Connexion" vs. "Se connecter"

@aduth
Copy link
Contributor

aduth commented Oct 23, 2023

Could you clarify where specifically you got these labels from?

Oh, I missed that you linked to the source in your original comment. I still think the question stands about figuring out which variant we want to use here.

@kevinsmaster5
Copy link
Contributor Author

Could you clarify where specifically you got these labels from?

Oh, I missed that you linked to the source in your original comment. I still think the question stands about figuring out which variant we want to use here.

Se connecter sounds better to me but I defer to a more informed opinion.

@mdiarra3
Copy link
Contributor

Se Connecter would be the verb/action and makes more sense than Connection.

resend: Renvoyer
reverify: Veuillez vérifier votre identité de nouveau.
sign_in: Connexion
sign_out: Déconnexion
Copy link
Contributor

@aduth aduth Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably split this out to a separate ticket, but based on the prior conversation about verb forms of the translation, I think we'd want to revisit "Déconnexion" as well, since this reads to me as a noun.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kevinsmaster5 kevinsmaster5 merged commit 206d240 into main Oct 23, 2023
@kevinsmaster5 kevinsmaster5 deleted the kmas-lg-10996-fix-spanish-french-sign-in branch October 23, 2023 20:33
@mdiarra3 mdiarra3 mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants