LG-11344: Prompt at most once for WebAuthn authentication#9428
Merged
Conversation
changelog: Bug Fixes, Face or Touch Unlock, Prompt at most once when clicking submission button multiple times
jmdembe
approved these changes
Oct 23, 2023
kevinsmaster5
approved these changes
Oct 23, 2023
Contributor
kevinsmaster5
left a comment
There was a problem hiding this comment.
It looks good. Local test confirmed working as expected.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11344
🛠 Summary of changes
Disables button for Face or Touch Unlock sign-in or setup when clicked, to avoid a scenario where multiple clicks due to a delay in the OS prompt may cause the user to see multiple prompt windows.
📜 Testing Plan
Sign-in:
Account creation:
show_unsupported_passkey_platform_authentication_setupistrue(e.g. local development)👀 Screenshots
In the screenshots below, observe that the darker button indicates the active, disabled state of the button, as implemented through
SubmitButtonComponent.Account creation:
Sign in: