Remove USWDS prose styles from application stylesheet#9445
Merged
Conversation
changelog: Internal, Performance, Reduce size of application stylesheet
mitchellhenke
approved these changes
Oct 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes USWDS Prose component styles from the application stylesheet, to further optimize its output size and compile times.
We only had a single reference to this in the accordion component. While the source example component code for accordion does prescribe
usa-prose, the only meaningful impact I could tell is the enforcement of a maximum width on the text. Since our Figma references for the accordion component don't apply this maximum text width (cc @nickttng) and we generally don't use "prose" styling, I think it should be safe and consistent to remove.This also updates asset size budgets to be more aggressively small.
An upstream pull request to USWDS at uswds/uswds#5577 will further optimize size by about 0.1kb Brotli'd when paired with this change. I couldn't find an elegant way to monkey-patch it here.
Performance
Before: 26.9kb
After: 25.3kb
Diff: -1.6kb (-5.9%)
📜 Testing Plan
Verify there are no visual regressions, particularly in the use of accordion components.