Merged
Conversation
changelog: Internal, Telephony, Provide Sender ID for UK SMS
mdiarra3
approved these changes
Oct 26, 2023
mitchellhenke
approved these changes
Oct 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11422
🛠 Summary of changes
Adds UK to the set of sender ID countries so that the preconfigured sender ID is provided for SMS to the country.
Source for how Sender ID is configured using our single static Sender ID:
identity-idp/config/initializers/telephony.rb
Lines 16 to 19 in a1df492
Reference that Sender ID is supported without registration (see "Yes" under "Supports Sender ID", notably not "Registration required"):
https://docs.aws.amazon.com/pinpoint/latest/userguide/channels-sms-countries.html
Reference that "GB" is the country identifier:
identity-idp/config/pinpoint_supported_countries.yml
Lines 317 to 321 in a1df492
Slack discussion: https://gsa-tts.slack.com/archives/C01710KMYUB/p1698267798949799
📜 Testing Plan
I'm not aware that there's a way to test this.