Skip to content

LG-11422: Provide Sender ID for UK SMS#9456

Merged
aduth merged 1 commit intomainfrom
aduth-lg-11422-sender-id-uk
Oct 26, 2023
Merged

LG-11422: Provide Sender ID for UK SMS#9456
aduth merged 1 commit intomainfrom
aduth-lg-11422-sender-id-uk

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Oct 26, 2023

🎫 Ticket

LG-11422

🛠 Summary of changes

Adds UK to the set of sender ID countries so that the preconfigured sender ID is provided for SMS to the country.

Source for how Sender ID is configured using our single static Sender ID:

c.country_sender_ids = IdentityConfig.store.pinpoint_sms_sender_id.presence &&
PinpointSupportedCountries::SENDER_ID_COUNTRIES.index_with do
IdentityConfig.store.pinpoint_sms_sender_id
end

Reference that Sender ID is supported without registration (see "Yes" under "Supports Sender ID", notably not "Registration required"):

https://docs.aws.amazon.com/pinpoint/latest/userguide/channels-sms-countries.html

Reference that "GB" is the country identifier:

GB:
country_code: '44'
name: United Kingdom
supports_sms: true
supports_voice: true

Slack discussion: https://gsa-tts.slack.com/archives/C01710KMYUB/p1698267798949799

📜 Testing Plan

I'm not aware that there's a way to test this.

changelog: Internal, Telephony, Provide Sender ID for UK SMS
@aduth aduth merged commit f8ee126 into main Oct 26, 2023
@aduth aduth deleted the aduth-lg-11422-sender-id-uk branch October 26, 2023 13:35
@mdiarra3 mdiarra3 mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants