Merged
Conversation
changelog: User-Facing Improvements, Page Title, Improve consistency and accessibility of page title text
… back to SP (#8334) * Add exit link to session_errors failure view * Update controller spec View now refers to @sp_name rather than decorated_session.sp_name * Update copy on session/errors/failure Updated heading, modified emphasis in body. * changelog: User-Facing Improvements, Identity verification, Improve language on rate limiting error screen * Render step indicator on session_errors/failure.html.erb * Update config/locales/idv/fr.yml Co-authored-by: Doug Price <douglas.price@gsa.gov> * normalize that yaml --------- Co-authored-by: Doug Price <douglas.price@gsa.gov>
changelog: User-facing improvements, In-person Proofing, re-add the secondary ID instructions to web & email
changelog: User-Facing Improvements, Account Creation, Improve support for browsers to prompt user to save password for new account
… setup (#8364) * changelog: Internal, Authentication, Add logging for Additional phone setup * add analytics events * add phone visit * fix analytics events to be clearer * analytics events change name * fix analytics * rubocop * capitalization * capitalize spec
…est (#8363) * Add gpo_max_profile_age_to_send_letter_in_days config * Wire up @user_can_request_another_gpo_code in GpoVerifyController * Wire up @user_can_request_another_gpo_code in view * Guard against viewing / submitting GPO form if profile too old * changelog: Internal, GPO, Prevent requesting another GPO code when profile is too old. * Add feature tests for GPO resend blocking - Test that the user is not presented the option to resend after too much time - Test that the user can't navigate to the resend page after too much time * Update app/services/idv/gpo_mail.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
[skip changelog]
…8373) changelog: Internal, In-Person Proofing, Log the residential address proofing result of DAV in analytics event.
* Remove `FeatureManagement.document_capture_async_uploads_enabled?` method and specs * Remove IdentityConfig.store.doc_auth_enable_presigned_s3_urls * Remove initializer to guard against turning on async doc capture * Remove ImageUploadPresignedUrlGenerator and usage * Remove AwsS3Helper and associated Identity::Hostdata::EC2 in specs * Remove unused ApiDocumentVerificationStatusForm * Remove Api::Verify::DocumentCaptureController and Forms::ApiDocumentVerificationForm * Remove unused Api::Verify::DocumentCaptureErrorsController and BaseController changelog: Internal, Code Cleanup, remove async document capture code * Remove translation tag document_verification_timeout * Remove DocumentProofingJob * Remove DocumentCaptureErrorsDeleteForm --------- Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
* build-sass: Add support for ".scss" extension changelog: Internal, Build Tooling, Improve filename extension flexibility for stylesheet compilation * Ignore fixture files for Stylelint
* remove 404 action form LinkSentController * remove 404 status test * [skip changelog] --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain>
* log nontransliterable chars * refactor * add spec * changelog: Internal, Transliterable Validator, log nontransliterable characters
… way for a user to cancel and return to SP (#8351) * LG-9298 Warning screen for “Verify your information” should include a way for a user to cancel and return to SP changelog: User-Facing Improvements, Identity verification, Improve language on warning screen for verify info and allow user to return to SP * restore remaining attempts * happy linting * add idv.warning i18n for fr and es * happy linting * update headings idv session warnings * fix tests * fix tests * allow user to cancel with rate limited during ssn proofing * add idv.warning.attempts to ignore unused keys * remove unused i18n keys idv.troubleshooting.options.add_photos * Remove unused variant strings Co-Authored-By: Amir Reavis-Bey <1261794+amirbey@users.noreply.github.com> --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
… in IdvStepConcern (#8378) * Pending before actions in IdvStepConcern changelog: User-facing Improvements, Identity Verification, ensure that users waiting for a letter or in person verification see the correct page when entering Identity Verification. * Rename #confirm_no_pending_profile to #confirm_no_pending_gpo_profile * Add specs for #confirm_no_pending_in_person_enrollment * Add specs for #confirm_no_pending_gpo_profile before action And add a Factory for a user with a gpo pending profile * Add to feature spec to confirm user cannot visit IdV pages with pending letter * Add to feature spec to confirm user awaiting in person verification cannot visit IdV pages --------- Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> Co-authored-by: Eric Gade <eric.gade@gsa.gov>
* read new gpo timestamp * add new gpo_pending_profile methods * change deactivation reasons in tests * add changelog changelog: Internal, IdV GPO Flow, Read from gpo_verification_pending_at column * first pass at making tests pass * fixed logic around gpo and fraud review verification
* LG-9828:Warning screen for “Verify your information [skip changelog] * happy linting --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain>
* Fix new link_sent page back link Needed to use idv_doc_auth_step_url instead of idv_doc_auth_url [skip changelog] --------- Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> (cherry picked from commit a25df86)
mdiarra3
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal