LG-9611 Remove async document capture code#8377
Conversation
…thod and specs Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
and Forms::ApiDocumentVerificationForm
and BaseController
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Sad to see it go, but certainly a boon for maintainability!
| front_image_upload_url: front_image_upload_url, | ||
| back_image_upload_url: back_image_upload_url, |
There was a problem hiding this comment.
These control a cascading set of behaviors in the JavaScript that should now be safe to remove as well. I'm to blame for some (bad) "clever" code which made it hard to search for. All of the JavaScript's "async" behaviors are tied to this (isAsyncForm, withBackgroundEncryptedUpload, etc.).
|
Related, we should probably update https://handbook.login.gov/articles/appdev-proofing-ruby-worker-jobs.html to note what has been removed? (obviously a separate codebase so don't let that block this PR) jmax 5/11/23 - Opened https://cm-jira.usa.gov/browse/LG-9795 to take care of this |
soniaconnolly
changed the title
Yeah, it looks like a ton of work went into this. |
Looks like this endpoint was removed in #8377, and I'm seeing 404s in our logs from users still making this API call. [skip changelog]
Looks like this endpoint was removed in #8377, and I'm seeing 404s in our logs from users still making this API call. [skip changelog]
3 participants
🎫 Ticket
LG-9611
🛠 Summary of changes
Remove all the code and specs associated with Async Document Capture. This is a followup to #8292, cleanup after removing DocumentCapture from the FSM.
Note: In the preceding PR, a comment from @jskinne3 suggested getting rid of the status_endpoint argument in _document_capture.html.erb. There are references to StatusEndpoint in frontend code, so it's not clear to me if status_endpoint is used, or if there is frontend code that can also be deleted.
The feature flag has been off in production, so this shouldn't cause any issues in the 50/50 state.
📜 Testing Plan