Conversation
…ofile is too old.
- Test that the user is not presented the option to resend after too much time - Test that the user can't navigate to the resend page after too much time
matthinz
force-pushed
the
matthinz/9561-gpo-send-another-letter-timeout
branch
from
397a195 to
1bd5aa4
Compare
matthinz
changed the title
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
approved these changes
May 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9561
🛠 Summary of changes
Add a new config,
gpo_max_profile_age_to_send_letter_in_days, which can be used to limit the amount of time after a profile is first created we allow requesting a GPO letter to verify it. The default value for this config is 30 days, calculated from thecreated_atof theProfile.When the user is outside this window of time, they are no longer offered the option to "Send me another letter" on the GPO verification page--they can either enter the OTP that was already mailed to them or restart the proofing process.