LG-9524: log residential address resolution in event.#8373
Merged
dawei-nava merged 1 commit intomainfrom May 11, 2023
Merged
Conversation
dawei-nava
force-pushed
the
dawei/LG-9524-resolution-proofing-job-log
branch
from
71ced26 to
0e258a4
Compare
dawei-nava
changed the title
Contributor
|
This is failing on gitlab b/c it's missing the changelog message, has a linting issue (running rubocop -a will likely fix the lint issue) and has tests failing in |
changelog: Internal, In-Person Proofing, Log the residential address proofing result of DAV in analytics event.
dawei-nava
force-pushed
the
dawei/LG-9524-resolution-proofing-job-log
branch
from
0e258a4 to
0edc109
Compare
eileen-nava
approved these changes
May 11, 2023
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
LGTM! I am including a screenshot of what I saw in events.log
The double address verification flag is logged
The residential address resolution is logged
👏🏻 👏🏻 👏🏻
| expect(result_context_stages_resolution[:attributes_requiring_additional_verification]). | ||
| to eq([]) | ||
|
|
||
| # result[:context][:stages][:residential_address] |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9524: Update logs for resolution proofing job
🛠 Summary of changes
Log result of residential address proofing in event log.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.