LG-8319: Re-add the secondary ID instructions to web page and email#8376
Merged
tomas-nava merged 1 commit intomainfrom May 10, 2023
Merged
Conversation
changelog: User-facing improvements, In-person Proofing, re-add the secondary ID instructions to web & email
night-jellyfish
approved these changes
May 10, 2023
Contributor
night-jellyfish
left a comment
night-jellyfish
left a comment
There was a problem hiding this comment.
I walked through this with Tomas and also pulled the branch down to try it to make sure. It looks good to me! Thanks again for fixing it so quickly.
Contributor
|
I observed the app running locally - item 4 Show proof of your current address displayed on barcode view and email template when user said they had a different address listed on their ID locally and did not display when the user had the same address listed. No concerns |
gina-yamada
approved these changes
May 10, 2023
kellular
approved these changes
May 10, 2023
kellular
left a comment
kellular
left a comment
There was a problem hiding this comment.
Tomas demo'd both paths (current address on ID vs different current address) for me on Google Meet. Lgtm 👍 Thanks so much
NavaTim
approved these changes
May 10, 2023
Merged
soniaconnolly
pushed a commit
that referenced
this pull request
May 10, 2023
changelog: User-facing improvements, In-person Proofing, re-add the secondary ID instructions to web & email
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8319
🛠 Summary of changes
Re-adds the secondary ID instructions to the Ready to Verify page and emails when appropriate. See this slack thread for context.
Screenshots
DAV on, address does not match (web)
DAV on, address does not match (email)
DAV off, address does match (web)
DAV off, address does match (email)
DAV off, address does not match (web)
DAV off, address does not match (email)