Deploy RC 280 to Prod

.stylelintrc.json

@@ -1,3 +1,4 @@
 {
-  "extends": "@18f/identity-stylelint-config"
+  "extends": "@18f/identity-stylelint-config",
+  "ignoreFiles": "**/fixtures/**/*"
 }

app/controllers/concerns/idv_step_concern.rb

@@ -6,6 +6,17 @@ module IdvStepConcern
   included do
     before_action :confirm_two_factor_authenticated
     before_action :confirm_idv_needed
+    before_action :confirm_no_pending_gpo_profile
+    before_action :confirm_no_pending_in_person_enrollment
+  end
+
+  def confirm_no_pending_gpo_profile
+    redirect_to idv_gpo_verify_url if current_user.pending_profile_requires_verification?
+  end
+
+  def confirm_no_pending_in_person_enrollment
+    return if !IdentityConfig.store.in_person_proofing_enabled
+    redirect_to idv_in_person_ready_to_verify_url if current_user.pending_in_person_enrollment
   end
 
   def flow_session

app/controllers/idv/document_capture_controller.rb

@@ -36,22 +36,11 @@ def update
     end
 
     def extra_view_variables
-      url_builder = ImageUploadPresignedUrlGenerator.new
-
       {
         document_capture_session_uuid: flow_session[:document_capture_session_uuid],
         flow_path: 'standard',
         sp_name: decorated_session.sp_name,
         failure_to_proof_url: return_to_sp_failure_to_proof_url(step: 'document_capture'),
-
-        front_image_upload_url: url_builder.presigned_image_upload_url(
-          image_type: 'front',
-          transaction_id: flow_session[:document_capture_session_uuid],
-        ),
-        back_image_upload_url: url_builder.presigned_image_upload_url(
-          image_type: 'back',
-          transaction_id: flow_session[:document_capture_session_uuid],
-        ),
       }.merge(
         acuant_sdk_upgrade_a_b_testing_variables,
         in_person_cta_variant_testing_variables,

app/controllers/idv/gpo_controller.rb

@@ -7,6 +7,7 @@ class GpoController < ApplicationController
     before_action :confirm_idv_needed
     before_action :confirm_user_completed_idv_profile_step
     before_action :confirm_mail_not_spammed
+    before_action :confirm_profile_not_too_old
 
     def index
       @presenter = GpoPresenter.new(current_user, url_options)
@@ -38,6 +39,10 @@ def gpo_mail_service
 
     private
 
+    def confirm_profile_not_too_old
+      redirect_to idv_path if gpo_mail_service.profile_too_old?
+    end
+
     def step_indicator_current_step
       if resend_requested?
         :get_a_letter

app/controllers/idv/gpo_verify_controller.rb

@@ -10,10 +10,14 @@ class GpoVerifyController < ApplicationController
     def index
       analytics.idv_gpo_verification_visited
       gpo_mail = Idv::GpoMail.new(current_user)
-      @mail_spammed = gpo_mail.mail_spammed?
       @gpo_verify_form = GpoVerifyForm.new(user: current_user, pii: pii)
       @code = session[:last_gpo_confirmation_code] if FeatureManagement.reveal_gpo_code?
 
+      @user_can_request_another_gpo_code =
+        FeatureManagement.gpo_verification_enabled? &&
+        !gpo_mail.mail_spammed? &&
+        !gpo_mail.profile_too_old?
+
       if throttle.throttled?
         render_throttled
       else

app/controllers/idv/hybrid_mobile/document_capture_controller.rb

@@ -36,20 +36,10 @@ def update
       end
 
       def extra_view_variables
-        url_builder = ImageUploadPresignedUrlGenerator.new
-
         {
           flow_path: 'hybrid',
           document_capture_session_uuid: document_capture_session_uuid,
           failure_to_proof_url: return_to_sp_failure_to_proof_url(step: 'document_capture'),
-          front_image_upload_url: url_builder.presigned_image_upload_url(
-            image_type: 'front',
-            transaction_id: document_capture_session_uuid,
-          ),
-          back_image_upload_url: url_builder.presigned_image_upload_url(
-            image_type: 'back',
-            transaction_id: document_capture_session_uuid,
-          ),
         }.merge(
           native_camera_ab_testing_variables,
           acuant_sdk_upgrade_a_b_testing_variables,

app/controllers/idv/link_sent_controller.rb

@@ -5,7 +5,6 @@ class LinkSentController < ApplicationController
     include StepIndicatorConcern
     include StepUtilitiesConcern
 
-    before_action :render_404_if_link_sent_controller_disabled
     before_action :confirm_two_factor_authenticated
     before_action :confirm_upload_step_complete
     before_action :confirm_document_capture_needed
@@ -43,10 +42,6 @@ def extra_view_variables
 
     private
 
-    def render_404_if_link_sent_controller_disabled
-      render_not_found unless IdentityConfig.store.doc_auth_link_sent_controller_enabled
-    end
-
     def confirm_upload_step_complete
       return if flow_session['Idv::Steps::UploadStep']
 

app/controllers/idv/session_errors_controller.rb

@@ -28,6 +28,7 @@ def failure
         throttle_type: :idv_resolution,
       )
       @expires_at = throttle.expires_at
+      @sp_name = decorated_session.sp_name
       log_event(based_on_throttle: throttle)
     end
 

app/controllers/idv/sessions_controller.rb

@@ -43,7 +43,7 @@ def cancel_processing
     end
 
     def cancel_verification_attempt_if_pending_profile
-      return if current_user.profiles.gpo_verification_pending.blank?
+      return if !current_user.pending_profile?
       Idv::CancelVerificationAttempt.new(user: current_user).call
     end
 

app/controllers/users/phones_controller.rb

@@ -13,11 +13,13 @@ class PhonesController < ApplicationController
     def add
       user_session[:phone_id] = nil
       @new_phone_form = NewPhoneForm.new(user: current_user, analytics: analytics)
+      analytics.add_phone_setup_visit
     end
 
     def create
       @new_phone_form = NewPhoneForm.new(user: current_user, analytics: analytics)
       result = @new_phone_form.submit(user_params)
+      analytics.multi_factor_auth_phone_setup(**result.to_h)
       if result.success?
         confirm_phone
       elsif recoverable_recaptcha_error?(result)

app/forms/gpo_verify_form.rb

@@ -22,6 +22,7 @@ def submit
         UspsInPersonProofing::EnrollmentHelper.schedule_in_person_enrollment(user, pii)
         pending_profile&.deactivate(:in_person_verification_pending)
       elsif fraud_check_failed? && threatmetrix_enabled?
+        pending_profile&.remove_gpo_deactivation_reason
         deactivate_for_fraud_review
       else
         activate_profile
@@ -55,7 +56,6 @@ def gpo_confirmation_code
 
   def deactivate_for_fraud_review
     pending_profile&.deactivate_for_fraud_review
-    pending_profile&.update!(deactivation_reason: nil, verified_at: Time.zone.now)
   end
 
   def validate_otp_not_expired
@@ -94,6 +94,7 @@ def fraud_check_failed?
   end
 
   def activate_profile
-    user.pending_profile&.activate_after_gpo_verification
+    pending_profile&.remove_gpo_deactivation_reason
+    pending_profile&.activate
   end
 end