LG-9477 log nontransliterable chars#8379
Merged
svalexander merged 4 commits intomainfrom May 12, 2023
Merged
Conversation
app/services/usps_in_person_proofing/transliterable_validator.rb
Outdated
Show resolved
Hide resolved
zachmargolis
approved these changes
May 11, 2023
app/services/usps_in_person_proofing/transliterable_validator.rb
Outdated
Show resolved
Hide resolved
app/services/usps_in_person_proofing/transliterable_validator.rb
Outdated
Show resolved
Hide resolved
Comment on lines
+55
to
+58
| nontransliterable_chars = nontransliterable_chars.sort | ||
| analytics.idv_in_person_proofing_nontransliterable_characters_submitted( | ||
| nontransliterable_characters: nontransliterable_chars, | ||
| ) |
Contributor
There was a problem hiding this comment.
can remove the re-assignment and inline that too?
Suggested change
| nontransliterable_chars = nontransliterable_chars.sort | |
| analytics.idv_in_person_proofing_nontransliterable_characters_submitted( | |
| nontransliterable_characters: nontransliterable_chars, | |
| ) | |
| analytics.idv_in_person_proofing_nontransliterable_characters_submitted( | |
| nontransliterable_characters: nontransliterable_chars.sort, | |
| ) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9477
🛠 Summary of changes
Add an analytics event that logs nontransliterable characters that a user submits. An event will be logged for each group of fields where nontransliterable characters are present. The characters are sorted and duplicates are removed.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
F1r$t N@m3100 M@!n $tevents.loglogged event w/ the rejected characters100 M@!n $tevents.loglogged event w/ the rejected characters