LG-9741 Confirm no pending GPO or in person enrollment before actions in IdvStepConcern#8378
Merged
soniaconnolly merged 6 commits intomainfrom May 15, 2023
Merged
Conversation
changelog: User-facing Improvements, Identity Verification, ensure that users waiting for a letter or in person verification see the correct page when entering Identity Verification. Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> Co-authored-by: Eric Gade <eric.gade@gsa.gov>
And add a Factory for a user with a gpo pending profile
…annot visit IdV pages
soniaconnolly
force-pushed
the
sonia-lg-9741-pending-before-actions
branch
from
ce5e372 to
e49c516
Compare
jmhooper
approved these changes
May 15, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9741
🛠 Summary of changes
Ensure that users waiting for a letter or in person verification see the correct page when entering Identity Verification. Add before actions to IdvStepConcern, which is included in all the post-FSM controllers. These before actions already existed in doc_auth_controller, where they apply to steps inside the FSM.
Now with added concern and feature specs. Note that the feature specs pass even when the new before actions are commented out because doc_auth_controller still has our backs. These before actions will be needed as we pull more steps out of the FSM.