Skip to content

LG-9535 Read from new gpo column#8381

Merged
theabrad merged 6 commits intomainfrom
abrad-lg-9535-read-from-gpo-column
May 15, 2023
Merged

LG-9535 Read from new gpo column#8381
theabrad merged 6 commits intomainfrom
abrad-lg-9535-read-from-gpo-column

Conversation

@theabrad
Copy link
Contributor

🎫 Ticket

LG-9535

🛠 Summary of changes

We now read from the new gpo_verification_pending_at column for deactivation reasons instead of the old enum.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Go through IdV GPO flow.
  • Confirm that everything is working correctly.

@theabrad theabrad requested a review from a team May 11, 2023 15:45
Comment on lines 109 to +111
def pending_profile
profiles.gpo_verification_pending.order(created_at: :desc).first
gpo_verification_pending_profile
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this method? or just alias it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was inbetween removing this method or keeping it. I was thinking of keeping it for if we have any other reasons to have a pending_profile in the future.

end

def pending_profile
profiles.gpo_verification_pending.order(created_at: :desc).first
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also are we going to backfill this data? do we need to have "double-read" paths to make sure older records get handled correctly here?

Copy link
Contributor Author

@theabrad theabrad May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already done the backfill. In ROLL-0008

Copy link
Contributor

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Comment on lines +12 to +15
profile.update!(
active: false,
deactivation_reason: :verification_cancelled,
gpo_verification_pending_at: nil,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to set anything to do with the fraud timestamps here as well? Or are we keeping whatever is there, even if the user cancels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question that i'll find the answer to.

@theabrad theabrad merged commit 46ccb44 into main May 15, 2023
@theabrad theabrad deleted the abrad-lg-9535-read-from-gpo-column branch May 15, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants