Conversation
View now refers to @sp_name rather than decorated_session.sp_name
Updated heading, modified emphasis in body.
…anguage on rate limiting error screen
matthinz
force-pushed
the
matthinz/9295-verify-rate-limit-sp-link
branch
from
cef81c1 to
88c9818
Compare
|
👋🏿 @matthinz ... looks like i'm not able yet to provide a review ... LGTM, but i think we still have to add the progress bar at the top? it's not annotated on the image in ticket ... happened to me too 😄 |
| 'idv/shared/error', | ||
| title: t('titles.failure.information_not_verified'), | ||
| heading: t('idv.failure.sessions.heading'), | ||
| current_step: :verify_info, |
There was a problem hiding this comment.
I think this may cause an issue with the hybrid flow (which currently can't use the step indicator concern) and could run into the same issue described here
There was a problem hiding this comment.
The view doesn't attempt to render a step indicator if StepIndicatorConcern hasn't been included (that's the defined?(step_indicator_steps) here), so it should be to leave this line in, then re-enable StepIndicatorConcern when it's hybrid-compatible.
There was a problem hiding this comment.
Sorry, yes, as long as the StepIndicatorConcern is not reintroduced to the controller before then, it should be fine! The comment above was written before #8339 was merged and I wasn't sure if that was the path we were going to take to resolve the issue in the near-term.
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Looks good - one comment about a missing translation update.
Co-authored-by: Doug Price <douglas.price@gsa.gov>
4 participants
🎫 Ticket
LG-9295
🛠 Summary of changes
Tweaks to the rate limit error screen shown on the "Verify your information" step of IdV. Includes:
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
With SP
Without SP
After:
With SP
Without SP