Deploy RC 226 to Production#7328
Merged
mitchellhenke merged 22 commits intostages/prodfrom Nov 10, 2022
Merged
Conversation
* LG-7086-log-whether-account-is-in-reproofing changelog: Improvements, Logging, Log if reproofing for IRS * Update app/services/flow/flow_state_machine.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Updated current_user to use effective_user * Added spec for reproof_for_irs? true Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
**Why**: transient attributes on AR models can be confusing, this makes it clear it's not persisted [skip changelog]
changelog: Internal, Performance, Optimize to reduce database queries
changelog: Internal, Dependencies, Upgrade NewRelic
* Update IDv welcome page structure
Lay out new structure for welcome text.
* Add new English text
* Spanish translation
* French translation
* Update config/locales/doc_auth/en.yml
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Remove %{learn_more_link}
Render link separately (and don't use `_html` for the translation key).
(Also, run stuff through `make normalize_yaml`)
changelog: Improvements, Identity verification, Clarify language on around how we use your phone number to verify your identity
* Update tests for IDV welcome step
We now have the "Learn more..." link on the page twice. Log separate events for each click.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Adding attempt events packaging batch job. changelog: Internal, Attempts API, Add batch job to package events. * cleaned up comments and added tests for attempts_events_batch_job * cleanup per draft PR feedback * linter fixes * Update app/jobs/irs_attempts_events_batch_job.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/jobs/irs_attempts_events_batch_job.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * lint fixes * fixed unit test after merging suggested changes * lint fix * Implemented test changes based on feedback Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Remove UniqueMonthlyAuthsReport * Remove UniqueMonthlyAuthCounts * Remove UniqueYearlyAuthsReport * Remove UniqueYearlyAuthCounts * Remove IaaBillingReport * Remove Db::MonthlySpAuthCount::SpMonthTotalAuthCounts * Stop writing MonthlySpAuthCount rows (LG-8029) changelog: Internal, Reporting, Remove unused reporting code and stop writing unused data
LG-8010 Simplify return object to just JWEs changelog: Internal, Attempts API, Only Return JWEs Co-authored-by: Matt Wagner <mattwagner@navapbc.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Luis H. Matos <ThatSpaceGuy@users.noreply.github.com>
* changelog: Improvements, In-Person Proofing, creates controller for address search * Allow disabled and remove redundancies * Don’t include the namespace and reference directly * Use fewer wrapper methods for simplicity * Remove variable assignment * Update app/controllers/idv/in_person/address_search_controller.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/controllers/idv/in_person/address_search_controller.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Add test for no returned suggestions * Use POST verb to avoid PII leakage in logs * Hide address search behind feature flag Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* LG-7947: Remove "top" position for password toggle changelog: Bug Fixes, Accessibility, Improve tab order for password field visibility toggle * Disable password toggle as left-aligned, unbordered * Increase margin for reverify submit button * Increase margin between password toggle and password strength See: https://gsa-tts.slack.com/archives/C01710KMYUB/p1667585776233399?thread_ts=1667496041.397299&cid=C01710KMYUB * Adjust password toggle spacing See: https://gsa-tts.slack.com/archives/C01710KMYUB/p1667855547222989?thread_ts=1667496041.397299&cid=C01710KMYUB
* Removed graceful handling of "all clients failed to build" [skip changelog]
* LG-8050 | Attempts API timestamp parsing fix Match what the IRS is actually sending Sneaks in an unrelated change to the generated filename to accommodate a request they had. Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
#7317) * Revert "Remove concurrency limits from scheduled cron jobs in GoodJob (#7197)" This reverts commit 65fe73f. **Why**: We discovered daily jobs like the GpoDailyJob were running twice in the same day, indicating we still need these guards changelog: Internal, GoodJob, Add back in concurrency limits from scheduled cron jobs
* Re-enable GoodJob's preserve_old_records **Why**: To help make sure that daily scheduled jobs don't get re-run because we use the concurrency_key on old records to check for duplicates * Add changelog changelog: Internal, GoodJob, Bring back preserving old records to help prevent duplicate runs
…oding (#7321) **Why**: Request from partners changelog: Internal, Attempts API, Update filename checksum
… USPS API (#7302) * LG-7819: Modify enrollment creation CLI tool to create enrollments in USPS API changelog: Internal, In-Person Proofing, Update enrollment CLI tool to support enrollment creation in USPS IPPaaS API * Remove redundant falsy fallback Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> * LG-7819: Add comment describing reason for number conversion in last name Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
* Rename current Phone Finder response file rdp1_response.json * Add the file I renamed * Different methods for rdp1 and rdp2 * Add rdp2 fixture * Add PII warnings into data * Simplify skipping the logging of passing products * Delete ParameterDetails, test rdp1 and rdp2 passing * Unneeded comment * [changelog: Added Proofer RDP2 support] * changelog: Added, Proofing, Support for LN RDP2 without PII logging * [skip changelog] * PhoneFinder only * Add RDP2 fail response fixture from LN * Create RDP2 test, check that ParameterDetails key is removed
* Remove OMB Fitara report * Remove SpCostReport * Remove TotalSpCostReport * Remove DocAuthFunnelReport * Remove DocAuthDropOffRatesReport, DocAuthDropOffRatesPerSprintReport * Remove SpActiveUsersOverPeriodOfPerformanceReport * Also SpActiveUserCountsWithinIaaWindow * Move DocAuthLog STEPS constant * Remove now-unused DocAuthLog.verified_users_count changelog: Internal, Reporting, Remove unused reporting code Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
* LG-8044 De-duplicate email_confirmation event changelog: Internal, Attempts API, Standardize events
…7310) Change behavior of "skip to content link" on account page changelog: Improvements, Accessibility, Improve accessibility link on account page (LG-7949)
mitchellhenke
requested review from
NavaTim,
aduth,
jc-gsa,
matthinz,
n1zyy and
zachmargolis
zachmargolis
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Internal
!!! Invalid Changelog Entries !!!
LG-8050 | Attempts API timestamp parsing fix (#7316)