Remove concurrency limits from scheduled cron jobs in GoodJob#7197
Merged
mitchellhenke merged 2 commits intomainfrom Oct 24, 2022
Merged
Remove concurrency limits from scheduled cron jobs in GoodJob#7197mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
changelog: Internal, GoodJob, Remove concurrency limits from scheduled cron jobs in GoodJob
zachmargolis
approved these changes
Oct 24, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
Nice find! I'm so glad that the library handles this for us. We're past v2.5.0 right?
Contributor
Author
Yep, we're on v3.4.4 now and #7196 takes us to v3.6.0 |
Merged
zachmargolis
added a commit
that referenced
this pull request
Nov 8, 2022
#7317) * Revert "Remove concurrency limits from scheduled cron jobs in GoodJob (#7197)" This reverts commit 65fe73f. **Why**: We discovered daily jobs like the GpoDailyJob were running twice in the same day, indicating we still need these guards changelog: Internal, GoodJob, Add back in concurrency limits from scheduled cron jobs
zachmargolis
added a commit
that referenced
this pull request
Nov 8, 2022
#7317) * Revert "Remove concurrency limits from scheduled cron jobs in GoodJob (#7197)" This reverts commit 65fe73f. **Why**: We discovered daily jobs like the GpoDailyJob were running twice in the same day, indicating we still need these guards changelog: Internal, GoodJob, Add back in concurrency limits from scheduled cron jobs (cherry picked from commit 3e8d252)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Using the concurrency control limits has some performance impacts, but our usage of them should be unnecessary at this point (as mentioned in bensheldon/good_job#731)