Stop writing, reading sp_monthly_auths_count (LG-8029)#7312
Merged
zachmargolis merged 4 commits intomainfrom Nov 8, 2022
Merged
Stop writing, reading sp_monthly_auths_count (LG-8029)#7312zachmargolis merged 4 commits intomainfrom
zachmargolis merged 4 commits intomainfrom
Conversation
* Also UniqueMonthlyAuthCounts
* Also UniqueYearlyAuthCounts
* also Db::MonthlySpAuthCount::SpMonthTotalAuthCounts (cherry picked from commit 7f02da6eda6f41e47864ed83e4d81003b24b80a8)
[skip changelog]
mitchellhenke
approved these changes
Nov 8, 2022
Contributor
Author
|
Got confirmation in Slack, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Writing to sp_monthly_auth_counts takes up a lot of time during auth. However, the table is referenced by some reports
Based on access logs for S3, the last time any of those reports was accessed was January 2021
In #6952, we moved the reports we use to the "raw" sp_return_logs table, so we can still get the resulting data
Before Merging
Next steps