Merged
Conversation
* Also SpActiveUserCountsWithinIaaWindow
zachmargolis
force-pushed
the
margolis-drop-unused-reports
branch
from
396800b to
eff2cb8
Compare
changelog: Internal, Reporting, Remove unused reporting code
Contributor
Author
|
Ready for review! Got confirmation in Slack that these reports are not used |
aduth
approved these changes
Nov 9, 2022
| total_count = ::DocAuthLog.count | ||
| return {} if total_count.zero? | ||
| convert_percentages(total_count) | ||
| results['total_verified_users_count'] = ::DocAuthLog.verified_users_count |
Contributor
There was a problem hiding this comment.
Looks like this method DocAuthLog.verified_users_count is now unused? Should we remove it?
Contributor
Author
There was a problem hiding this comment.
great catch! will remove
Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this summary of S3 access logs going back to 2021, these reports have not been accessed during calendar year 2022
(Draft while we evaluate some of these)