Add connection pools for Pinpoint SMS, Voice senders#7314
Merged
zachmargolis merged 1 commit intomainfrom Nov 8, 2022
Merged
Conversation
* Removed graceful handling of "all clients failed to build" [skip changelog]
mitchellhenke
approved these changes
Nov 8, 2022
Contributor
Author
|
Confirmed that this worked on my sandbox, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hypothesis: similar to #7292, we might be able to save a lot of time in hot codepaths by making these API clients longer-lived,
Unfortunately, I don't think load testing will highlight changes from this because we mock SMS, Voice in our load tests but I do think a sandbox deploy will help confirm that these work.
One thing that this PR removes is graceful handling of "all clients failed to build" because it wasn't clear to me how to easily handle a nil value in a connection pool (because it's hard to evict/clear out items). For the time being we'll go with an Erlang-style "just let it fail" and we can look at different ways to recover from this effectively.
Recommended: view with whitespace changes hidden (
?w=1)