Conversation
|
|
||
| it 'is a successful rdp2 result' do | ||
| stub_request(:post, verification_request.url). | ||
| to_return(body: LexisNexisFixtures.phone_finder_rdp2_success_response_json, status: 200) |
There was a problem hiding this comment.
Do you think it is worthwhile to create separate RDP1 and RDP2 fixtures, and thus separate tests?
- The tests are otherwise identical in the case of
ProductStatusequal topassresponses - We don't yet have an official
failresponse from Monica (I recently asked for one) - A
failfixture will allow us to test if PII has been removed
There was a problem hiding this comment.
I think that this makes sense. I think a context for RDP1 and RDP2 makes sense at least until we are confident we are fully migrated to RDP2
There was a problem hiding this comment.
I do not seem to be getting an example fail case from LN so I guess I am ready to merge the tests I have.
There was a problem hiding this comment.
Update: I got a fail response example from LN and added it as the fixture rdp2_fail_response.json to this PR
| end | ||
| next if product['ProductStatus'] == 'pass' | ||
|
|
||
| product.delete('ParameterDetails') # don't log reflected PII |
There was a problem hiding this comment.
So, I think we may want the parameter details of some of the products. I think we want to delete parameter details for just the phonefinder product
There was a problem hiding this comment.
Thank you for the clarity. Changed!
| stub_request(:post, verification_request.url). | ||
| to_return(body: LexisNexisFixtures.phone_finder_rdp2_success_response_json, status: 200) | ||
|
|
||
| result = instance.proof(applicant) |
There was a problem hiding this comment.
This all looks good. Should we throw an expectation below somewhere to confirm that JSONified result doesn't include one of the PII fields?
There was a problem hiding this comment.
The test when the rdp2 response is a failure which I added below address this
|
👍🏾 |
3 participants
🎫 Ticket
LG-7907
🛠 Summary of changes
🚀 Notes for Deployment
None -- should work with RDP1 or RDP2 endpoint