Conversation
… USPS API changelog: Internal, In-Person Proofing, Update enrollment CLI tool to support enrollment creation in USPS IPPaaS API
…ley/lg-7819-usps-ippaas-job-create-via-api
sheldon-b
approved these changes
Nov 7, 2022
Contributor
sheldon-b
left a comment
There was a problem hiding this comment.
Looks good. Left a couple suggestions, none blocking
Comment on lines
+106
to
+108
| usps_compatible_number_alternative = n.to_s.chars.map do |c| | ||
| ('a'.ord + c.to_i).chr | ||
| end.join('') |
Contributor
There was a problem hiding this comment.
A comment here would aid readability, something as simple as
# Convert index to a string of letters to be a valid last name for the USPS API
| last_name: "User #{n}", | ||
| last_name: "User #{usps_compatible_number_alternative}", | ||
| dob: '1970-05-01', | ||
| ssn: "666-#{n}", # doesn't need to be legit 9 digits, just unique |
Contributor
There was a problem hiding this comment.
Do we need to worry about duplicates across multiple runs?
Contributor
Author
There was a problem hiding this comment.
Duplicates are expected, and that's fine.
Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
…ley/lg-7819-usps-ippaas-job-create-via-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7876
🛠 Summary of changes
CREATE_PENDING_ENROLLMENT_IN_USPStodev:random_in_person_userstask📜 Testing Plan
application.ymlconfig:usps_mock_fallbacktofalseusps_ipp_root_urlusps_ipp_usernameusps_ipp_passwordusps_ipp_sponsor_idusps_ipp_client_idIf you want to see more details of the USPS IPPaaS requests, then you can temporarily add a line like the following to
UspsInPersonProofing::Proofer.faraday. DO NOT do this in a deployed environment where the data could be ingested into logs.