Re-enable GoodJob's preserve_old_records#7320
Merged
zachmargolis merged 2 commits intomainfrom Nov 8, 2022
Merged
Conversation
**Why**: To help make sure that daily scheduled jobs don't get re-run because we use the concurrency_key on old records to check for duplicates
mitchellhenke
approved these changes
Nov 8, 2022
changelog: Internal, GoodJob, Bring back preserving old records to help prevent duplicate runs
zachmargolis
added a commit
that referenced
this pull request
Nov 8, 2022
* Re-enable GoodJob's preserve_old_records **Why**: To help make sure that daily scheduled jobs don't get re-run because we use the concurrency_key on old records to check for duplicates * Add changelog changelog: Internal, GoodJob, Bring back preserving old records to help prevent duplicate runs (cherry picked from commit f577eac)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To help make sure that daily scheduled jobs don't get re-run because we use the concurrency_key on old records to check for duplicates
Reverting part of #7196, related to #7317