Microoptimize reproof_for_irs to avoid database query#7307
Merged
Conversation
changelog: Internal, Performance, Optimize to reduce database queries
mitchellhenke
approved these changes
Nov 7, 2022
zachmargolis
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Optimizes
UserDecorator#reproof_for_irs?to avoid a database query by short-circuiting on a known value (service_provider) when possible. This avoids a database query for every non-IRS service provider.Inspired by #7279, since we're now logging the value of
reproof_for_irs?for every analytics event in identity verification.