LG-7947: Remove "top" position option for password toggle#7285
Merged
Conversation
aduth
commented
Nov 3, 2022
Contributor
Author
There was a problem hiding this comment.
Previously this component would forward all additional initializer attributes to the ValidatedFieldComponent. This made it easier to apply options to the field as an optimized use-case (contrast with new field_options), but (a) was inconsistent with other components which would apply additional attributes to the root element and (b) made it difficult or impossible to assign additional attributes to the root element (e.g. extra CSS classes).
aduth
force-pushed
the
aduth-lg-7947-pw-toggle
branch
from
4cd0b9f to
531590c
Compare
jc-gsa
approved these changes
Nov 4, 2022
mdiarra3
approved these changes
Nov 4, 2022
changelog: Bug Fixes, Accessibility, Improve tab order for password field visibility toggle
aduth
force-pushed
the
aduth-lg-7947-pw-toggle
branch
from
72e0fb4 to
9081a62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7947
🛠 Summary of changes
Revises all password toggles to display the toggle input below the password field, in order to correct tab order behavior such that the visual placement and tab order of the toggle always occurs after the password field.
Related Slack discussions:
👀 Screenshots