Merged
Conversation
#7244) This is necessary to prevent a bug where the "Reproof for IRS" modal appeared when users where proofing with IRS for the first time. Also, this makes logical sense since a user who has not proofed before cannot reproof [skip changelog]
* Upgrade NewRelic browser agent to latest changelog: Internal, Error Monitoring, Upgrade browser error monitoring agent to latest version * Restore newrelic_license_key to application.yml.default * Define only app ID and browser license key * Fix indentation on condition body Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> * Bump GitLab Co-authored-by: Zach Margolis <zbmargolis@gmail.com>
* Remove sleep from JavaScript tests changelog: Internal, Automated Tests, Improve runtime of automated tests * Bump GitLab
* Add and enforce image size attributes for rendered images changelog: Bug Fixes, Images, Improve image rendering to avoid page layout shifts * Remove debugging import See: #7248 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> Co-authored-by: Zach Margolis <zbmargolis@gmail.com>
* Render unauthenticated session expire redirect as meta tag changelog: Internal, Performance, Reduce JavaScript bundle size in critical paths * Update specs to reference IdentityConfig
* translations * reminder email * move date methods to inpersonenrollment model * update presenter and test * update tests * change variable name * user config value to calculate days * refactor days_remaining * Improvements, Email, reminder emails sent to users * lint fix * fix more lint issues * Improvements, Email, reminder emails sent to users * changelog: Improvements, Email, reminder emails sent to users * change days to day remaining * working on changes * Create shared view for ready to verify email body * Remove pending trait from with_service_provider * using service provider instead of issuer * remove unused issuer * remove job * normalize yaml * move heading to user mailer Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov> Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
…owser support outage (#7152) * changelog: Improvements, Browser Support, Show a banner for IE11 Users that their browser will not be supported, LG-7740 * remove unneeded pii banner * LG-7740: show ie11 not supported * LG-7740: update ie11 to new designs * show only for ie11 browser * changelog: Improvements, Broswer, Show IE11 Browser Support ending (LG-7740) * use exisitng component * add browser is ie11 check * normalize yaml and lint * replace name * update linting * use proper name
* remove selfie from acuant_client * removed liveness request from acuant client * remove acuant facial match request/response * remove acuant get_face_image * remove selfie from doc_auth_mock * [skip changelog] * remove liveness and selfie from document proofing job * re add selfie and liveness to acuant and set to nil * fix lint * readd liveness to document proofing job * 🚀 restart gitlab? * fixup
* Make analytics event matcher show diff when easy [skip changelog] * Use do/end instead of braces
* Add errors to inherited proofing mock proofer (7738) Why: So we can test the error paths in non-production environments changelog: Internal, Inherited Proofing, Mock errors for mock proofer * Rubocop -a * Invert logic for auth code * update ci
[skip changelog]
…7254) * LG-7943: Avoid showing in-person option for field validation errors changelog: Bug Fixes, In-person proofing, Show in-person option at intended troubleshooting scenarios * Collapse hasErrors, showInPersonOption to showAlternativeProofingOptions See: #7254 (comment)
* LG-7452 Add second error page when failure occurs and move them to inherited_proofing_errors_controller * changelog: Upcoming Features,InheritedProofing,NewErrorPages * normalize yml * Fix translatiosn * Remove partner help translation and us VA help entry
[skip changelog]
* Pulled out checks for liveness * Removed liveness_checking_enabled feature flag Background jobs still have liveness-related arguments.
) * LG-7760: Increase visibility of in-person proofing call-to-action changelog: Improvements, In-person proofing, Increase visibility of in-person proofing call-to-action * Refer to page field by label, not ID Since ID includes dynamic, incrementing value, and is not deterministic * Avoid asserting value 1. The tests run with async document uploads, which don't actually assign the value to the field, they upload directly to S3 2. We're already indirectly asserting the presence of a value by checking that the label name includes the file name ("logo.png") * Implement "Informative" as tag variant See: #7211 (comment) * Update final CTA heading translations * Remove legacy divider class
The methods are not longer used since IAL2 strict has been retired [skip changelog]
We no longer need to mock these responses. The IAL2 strict and liveness checking tooling has been deprecated and removed. [skip changelog]
* Log unexpected bad request errors to new relic changelog: Improvements, In-person proofing, log more error details * Fix lint failure
* Upgrade faraday gem - faraday_middleware is deprecated (instrumentation, auth now built-in) - retry is now in faraday-retry gem - basic_auth syntax changed * Simplify arcgis geocoder spec * Add content-type: application/json headers for stubbed responses * explicit JSON parsing * update retry_block arguments * update NewRelic::Agent.notice_error to send custom_params [skip changelog]
* Move LocationCollectionItem styles to document-capture stylesheet changelog: Internal, Performance, Reduce size of CSS stylesheets in critical paths * Remove duplicate border-dashed style definition changelog: Internal, Performance, Reduce size of CSS stylesheets in critical paths
[skip changelog]
We are no longer using selfies to proof since IAL2 strict is deprecated and being removed. This commit removes some of the tooling that enabled selfie upload. * [skip changelog]
This change is necessary since the Faraday upgrade. It looks like it got missed when the Faraday change was merged before this. This commit fixes a CI failure on main. [skip changelog]
changelog: Bug Fixes, Accessibility, Remove redundant and untranslated banner label
The code that quits calling the document proofing job with the selfie image and liveness enabled args is merged and deployed to prod. As such it should be safe to remove these args form the job. Additionally, the doc auth clients themselves should no longer be called with these args so they should be safe to remove from those as well. [skip changelog]
aduth
requested review from
holytoastr,
jmax-gsa,
jmhooper,
mmagsa,
rnagilla-gsa,
sheldon-b,
svalexander,
tomas-nava and
zachmargolis
zachmargolis
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Internal
Upcoming Features