Aggregate failures for flakey mailer specs#7251
Merged
Conversation
[skip changelog]
zachmargolis
approved these changes
Oct 31, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! seems worthwhile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Implements RSpec failure aggregation to run all assertions against expected email message before failing.
There are some flakey mailer specs (example) which are difficult to debug currently since it fails at the first assertion. It's hypothesized that the emails may be sent out of order, and it'd be helpful to have a fuller picture of the actual and expected results.
Easiest to review with whitespace hidden: https://github.com/18F/identity-idp/pull/7251/files?w=1
📜 Testing Plan
rspec