Skip to content

Remove redundant, untranslated banner label#7272

Merged
aduth merged 1 commit intomainfrom
aduth-rm-redundant-untranslated-banner-label
Nov 2, 2022
Merged

Remove redundant, untranslated banner label#7272
aduth merged 1 commit intomainfrom
aduth-rm-redundant-untranslated-banner-label

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Nov 1, 2022

🛠 Summary of changes

Removes the "banner" hard-coded label assigned to the site's banner header.

Why?

  • As a user of assistive technology, I expect that labels would be used to provide additional detail beyond a landmark's semantic default and would not otherwise be assigned, so that I am not exposed to duplicate / redundant information
  • As a user of assistive technology browsing Login.gov in a language other than English, I expect that labels would be translated in the page's current language, so that I am not confused by labels read in a different language

Related resources:

📜 Testing Plan

  • Ensure that you can navigate to the banner landmark with assistive technology in English and non-English locales

👀 Screenshots

English:

Observe that "banner" is only shown once.

Before After
Screen Shot 2022-11-01 at 3 16 25 PM Screen Shot 2022-11-01 at 3 16 10 PM

French:

Observe that the English word "banner" is no longer present.

Before After
Capture d’écran, le 2022-11-01 à 3 12 02 PM Capture d’écran, le 2022-11-01 à 3 11 21 PM

@aduth aduth requested a review from jmdembe November 1, 2022 19:28
changelog: Bug Fixes, Accessibility, Remove redundant and untranslated banner label
@aduth aduth force-pushed the aduth-rm-redundant-untranslated-banner-label branch from c0dad1e to 69fad9a Compare November 1, 2022 20:37
@aduth aduth merged commit a9f79eb into main Nov 2, 2022
@aduth aduth deleted the aduth-rm-redundant-untranslated-banner-label branch November 2, 2022 12:09
@aduth aduth mentioned this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants