Revert "Render unauthenticated session expire redirect as meta tag"#7273
Merged
Revert "Render unauthenticated session expire redirect as meta tag"#7273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7249
Related Slack conversation: https://gsa-tts.slack.com/archives/C0NGESUN5/p1667331820015699
The changes in #7249, while functionally equivalent to what had existed previously, introduce new errors flagged by accessibility testing tools related to
http-equiv="refresh". Future iterations should explore how to allow a user to extend the timeout, while remaining compatible with technical requirements for CSRF token expiration of 15 minutes.(Draft while I undo some of the diff to keep some desirable changes like template comment corrections and spec removal)Edit: Edited in 3438c5e.