LG-7452 Inherited Proofing Error Controller and new error page#7230
Merged
rnagilla-gsa merged 5 commits intomainfrom Oct 31, 2022
Merged
LG-7452 Inherited Proofing Error Controller and new error page#7230rnagilla-gsa merged 5 commits intomainfrom
rnagilla-gsa merged 5 commits intomainfrom
Conversation
…herited_proofing_errors_controller
rnagilla-gsa
added
inherited proofing
rnagilla-gsa
changed the title
aduth
reviewed
Oct 31, 2022
| text: t('inherited_proofing.troubleshooting.options.contact_support'), | ||
| new_tab: true, | ||
| }, | ||
| ].select(&:present?), |
Contributor
There was a problem hiding this comment.
There are no conditional members of the array, so #select(&present?) is unnecessary.
Suggested change
| ].select(&:present?), | |
| ], |
| need_assistance: 'Need immediate assistance? Here’s how to get help:' | ||
| need_help_updating: Need to update your information? Here’s how to get help | ||
| options: | ||
| get_partner_help: Get help at Partner Agency |
Contributor
There was a problem hiding this comment.
Can you confirm that this is meant to say "Partner Agency" and not some form of "VA" ? Typically I see "Partner Agency" used in designs as a placeholder for the actual partner's friendly name, which is then substituted with the partner's friendly_name.
identity-idp/config/locales/idv/en.yml
Line 199 in c2a3697
Contributor
Author
There was a problem hiding this comment.
@aduth What you mentioned is correct. I was using old figma's and confirmed it should say 'Get help at VA.gov'
aduth
approved these changes
Oct 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7452
Link to the relevant ticket.
🛠 Summary of changes
Write a brief description of what you changed.
📜 Testing Plan
/verify/inherited_proofing/errors/no_information
/verify/inherited_proofing/errors/failure
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After:
🚀 Notes for Deployment
Include any special instructions for deployment.