Remove selfie and liveness from Acuant#7240
Conversation
| image_metadata:, | ||
| analytics_data:, | ||
| flow_path:, | ||
| liveness_checking_enabled: nil |
There was a problem hiding this comment.
Since this is a background job we will need to keep this argument here. Otherwise when old hosts spawn a job we'll get an argument error when a new worker picks it up. We'll need to leave this in here until all the deployed hosts are running code that does not use this argument.
| back_image: back_image, | ||
| selfie_image: nil, | ||
| image_source: image_source(image_metadata), | ||
| liveness_checking_enabled: false, |
There was a problem hiding this comment.
I opened a pul request to manage these args here: #7235
tl;dr there is I think we need to leave these in with default values and remove the args form the callers. Once we are confident we have cleaned up all of the callers then we can pull these args.
There was a problem hiding this comment.
Wait, nevermind this is a caller. This is where we want to remove them. My comment applies to the code below in the AcuantClient
| back_image:, | ||
| selfie_image:, | ||
| image_source:, | ||
| liveness_checking_enabled: nil, |
There was a problem hiding this comment.
ok i'll add them back in
| image_metadata:, | ||
| analytics_data:, | ||
| flow_path:, | ||
| liveness_checking_enabled: nil |
There was a problem hiding this comment.
perform is the job arguments, liveness_checking_enabled is the one we need to keep I think? re: https://github.com/18F/identity-idp/pull/7240/files#r1007213954
There was a problem hiding this comment.
Yes, this argument needs to stay
3 participants
🛠 Summary of changes
Removing every trace of liveness and selfies from Acuant.