Updated .usa-alert--info-important style to bold text.#7258
Merged
Conversation
[skip changelog]
jmax-gsa
force-pushed
the
LG-7970-bolden-irs-reproofing-text
branch
from
a128fc0 to
07bd7ab
Compare
aduth
reviewed
Nov 1, 2022
| .usa-alert--info-important { | ||
| @include u-bg('accent-cool-darker'); | ||
| color: color('white'); | ||
| font-weight: 500; |
Contributor
There was a problem hiding this comment.
Because we only define 400 and 700 font weights, and due to how fallback weight behavior would choose the normal font weight, I wouldn't expect this change to have any effect, and in my testing it appears visually the same as if this line didn't exist at all.
If we wanted bold, I would expect...
Suggested change
| font-weight: 500; | |
| font-weight: bold; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
[https://cm-jira.usa.gov/browse/LG-7970]
🛠 Summary of changes
Set font-weight style on the style to 500, per slack conversation
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots