Skip to content

Add application/json header to in-person API call#7271

Merged
jmhooper merged 1 commit intomainfrom
jmhooper-fix-test
Nov 1, 2022
Merged

Add application/json header to in-person API call#7271
jmhooper merged 1 commit intomainfrom
jmhooper-fix-test

Conversation

@jmhooper
Copy link
Contributor

@jmhooper jmhooper commented Nov 1, 2022

This change is necessary since the Faraday upgrade. It looks like it got missed when the Faraday change was merged before this.

This commit fixes a CI failure on main.

This change is necessary since the Faraday upgrade. It looks like it got missed when the Faraday change was merged before this.

This commit fixes a CI failure on main.

[skip changelog]
@jmhooper jmhooper requested review from aduth and sheldon-b November 1, 2022 19:25
@jmhooper
Copy link
Contributor Author

jmhooper commented Nov 1, 2022

Quick refs to the PRs that go out of sync: #7260 and #7257.

From the comments on those it looks like the Faraday change required the tests to be structured a little differently. #7257 was branched off main without the Faraday change then merged into main with it.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you!

@jmhooper jmhooper merged commit 21f3804 into main Nov 1, 2022
@jmhooper jmhooper deleted the jmhooper-fix-test branch November 1, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants