Lg 7738 - mock errors for inherited proofing mock proofer#7243
Merged
holytoastr merged 4 commits intomainfrom Oct 31, 2022
Merged
Lg 7738 - mock errors for inherited proofing mock proofer#7243holytoastr merged 4 commits intomainfrom
holytoastr merged 4 commits intomainfrom
Conversation
Why: So we can test the error paths in non-production environments changelog: Internal, Inherited Proofing, Mock errors for mock proofer
Contributor
Author
|
I posted this in another comment, but just for visibility: Just for bigger picture context, since the auth code is provided by the VA when the user is sent to us we don't have a place where we would input the code the way you would with a phone number. In the end, I am envisioning a response like below once we have more than 2 auth_codes to work with. However, since we're agile, we're keeping it simple for now with a tertiary operator and will iterate as new codes are provided to us by the devs working on the VA api. PAYLOAD_HASH = {...}
ERROR_HASH_A = {...}
ERROR_HASH_B = {...}
GENERIC_ERROR_HASH = {...}
PAYLOAD_HASHES = {
Idv::InheritedProofing::Va::Mocks::Service::VALID_AUTH_CODE => PAYLOAD_HASH,
'error_a_auth_code' => ERROR_HASH_A,
'error_b_auth_code' => ERROR_HASH_B,
}
PAYLOAD_HASHES[auth_code] || GENERIC_ERROR_HASHHopefully you find that helpful and can approve this PR to help move it along |
zachmargolis
approved these changes
Oct 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7738
🛠 Summary of changes
Returns an error in the Inherited Proofing mock proofer when the incorrect auth code is provided