Skip to content

Deploy RC 214 to Prod#7071

Merged
aduth merged 17 commits intostages/prodfrom
stages/rc-2022-10-03
Oct 3, 2022
Merged

Deploy RC 214 to Prod#7071
aduth merged 17 commits intostages/prodfrom
stages/rc-2022-10-03

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Oct 3, 2022

Improvements

  • Authentication: Make state optional for OIDC Logout (#7045)
  • Authentication: Add logging of matching certificate for SAML AuthnRequests (#7047)
  • In-Person Proofing: Include new location in in-person proofing call-to-action (#7058)
  • In-Person Proofing: Send customer experience follow-up email (#7046)

Bug Fixes

  • Identity Verification: Fix display of personal key page layout (#7062)

Internal

  • Attempts API: Standardize events (#7044, #7059, #7060, #7064)
  • Inherited Proofing: User data on please verify page (#7065)
  • Localization: Support self-closing HTML tags in localization helper (#7034)
  • Logging: Log 2FA Setup Complete Event when skipping adding additional MFA (#7056)
  • OIDC Logout: Enable accepting client_id parameter by default (#7052)
  • Static Analysis: Update target platform versions for Rubocop analysis (#7055)
  • Styling Updates: Fixing icon positioning (#7061)

ThatSpaceGuy and others added 16 commits September 29, 2022 11:51
@ThatSpaceGuy
Adjust email parameter declaration (#7044)
238a0ee 
changelog: Internal, Attempts API, Standardize events
changelog: Internal, Logging, Log 2FA Setup Complete Event when skipp…
6a78378 
…ing adding additional MFA (#7056)
@aduth
Sync Rubocop target platform versions to current versions (#7055)
f89d579 
* Sync Rubocop target platform versions to current versions

changelog: Internal, Static Analysis, Update target platform versions for Rubocop analysis

* Correct new lint errors
@ThatSpaceGuy
Standardize default values for failure_reason (#7059)
b22458b 
changelog: Internal, Attempts API, Standardize events
@ThatSpaceGuy
Standardize success parameter to always be first (#7060)
13d3c76 
changelog: Internal, Attempts API, Standardize events
@orenyk
Make state optional for OIDC Logout (#7045)
b0f6956 
Resolves LG-7684

This brings us in alignment with the spec.

changelog: Improvements, Authentication, Make state optional for OIDC Logout
@orenyk
Add logging of matching certificate for SAML AuthnRequests (#7047)
189e84c 
Resolves LG-7676

Adds a new attribute to successful `SAML Auth` events to track the
serial number of the matching cert identified through signature
validation. If the signature validation fails, this attribute will be
`nil`, indicating that none of the configured SP public certificates
could be used to validate the signature in the SAML AuthnRequest.

changelog: Improvements, Authentication, Add logging of matching certificate for SAML AuthnRequests
Enable accepting client_id parameter by default (#7052)
2c45bb9 
changelog: Internal, OIDC Logout, Enable accepting client_id parameter by default
@ThatSpaceGuy
Clean up Phone confirmation events (#7064)
cdf6438 
changelog: Internal, Attempts API, Standardize events
@eric-gade
Fixing alert icon badge positioning (#7061)
0087afe 
also updating transform so Edge can deal with it

changelog: Internal, Styling Updates, fixing icon positioning
@stevegsa
LG-7640 review_status should be a top-level key (#7048)
89a9659
@holytoastr
Lg 7265 - Inherited Proofing - Display user data on Please Verify page (
a2417b7 
#7065)

* Display user data on the please verify page (#7265)

Why:
Inherited proofing users need to verify their data that has been imported is correct

changelog: Internal, Inherited Proofing, User data on please verify page

* Clean up specs

* Further clean up

* Remove remote proofing check

* Minor styling fixes - quick
@NavaTim
LG-7187: Send Customer Experience Follow-up Email for In-Person Proof…
f6dfc90 
…ing (#7046)

* LG-7187: Add follow-up survey field to in-person enrollments table

* LG-7187: Start implementing email for follow-up survey

* LG-7187: Style survey email and send on next partner sign-in

* LG-7187: Send survey when user shares info with partner; add fallback test URL for survey

* LG-7187: Test new survey DB query methods; format code

* LG-7187: Expand tests; require IAL2 usage to send survey email

* LG-7187: Add more tests relating to IPP survey email

* LG-7187: Finish writing feature test for in-person proofing survey email

* LG-7187: Fix unreliable tests and make IPP account creation reusable

* changelog: Upcoming Features, In-person proofing, Send Customer Experience Follow-up Email

* LG-7187: Add missing method to UserMailerPreview

* LG-7187: Improve query tests; update English survey email translation

* LG-7187: Combine paragraphs and use default margins/padding for survey email

* LG-7187: Reference constant for IAL2 in IPP completion survey logic

* LG-7187: Increase margin for paragraph above button
@aduth @allthesignals
react-i18n: Add support for self-closing elements in formatHTML (#7034)
9705e38 
* Split, convert react-i18n package to TypeScript

* react-i18n: Add support for self-closing elements in formatHTML

changelog: Internal, Localization, Support self-closing HTML tags in localization helper

* Add documentation for react-i18n

* Run Prettier on README

* Add (failing) regression coverage for dropped text

See: #7034 (comment)
Co-Authored-By: Matt Gardner <5004319+allthesignals@users.noreply.github.com>

* Fix dropped text following self-closing tag

Co-authored-by: Matt Gardner <5004319+allthesignals@users.noreply.github.com>
@allthesignals @aduth
LG-7620: Update IPP CTA language to include Baltimore option (#7058)
b17633c 
* Update IPP CTA language to include Baltimore option

Includes updates to FR, ES, and EN locales.

* Use formatHTML helper and br tag to generate newlines

* changelog: Improvements, In-Person Proofing, Include new location in IPP CTA

* Update README.md

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
@aduth
Fix personal key block display (#7062)
b1361b4 
* Fix personal key block display

changelog: Bug Fixes, Identity Verification, Fix display of personal key page layout

* Fix padding-y at all viewport sizes

* Remove unused key-badge styles

* Update spec selectors
@aduth
Copy link
Contributor Author

aduth commented Oct 3, 2022 •
edited
Loading

Failing build blocked by #7072. Merged and cherry-picked.

@aduth
Generate report in spec with the stubbed date (#7072)
6a4aa92 
**Why**: The job uses the passed date for the reporting range, so it should correspond to the date used in stubbing data, like what's done in other test cases in the file.

[skip changelog]
@aduth aduth merged commit d66b4e2 into stages/prod Oct 3, 2022
@aduth aduth deleted the stages/rc-2022-10-03 branch October 3, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchellhenke mitchellhenke mitchellhenke approved these changes

@holytoastr holytoastr Awaiting requested review from holytoastr

@allthesignals allthesignals Awaiting requested review from allthesignals

@ThatSpaceGuy ThatSpaceGuy Awaiting requested review from ThatSpaceGuy

@stevegsa stevegsa Awaiting requested review from stevegsa

@NavaTim NavaTim Awaiting requested review from NavaTim

+1 more reviewer

@orenyk orenyk orenyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status - promotion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@aduth @orenyk @mitchellhenke @ThatSpaceGuy @eric-gade @stevegsa @holytoastr @NavaTim @allthesignals