Skip to content

LG-7691 Fixing alert icon badge positioning#7061

Merged
eric-gade merged 1 commit intomainfrom
eric-lg-7691
Sep 30, 2022
Merged

LG-7691 Fixing alert icon badge positioning#7061
eric-gade merged 1 commit intomainfrom
eric-lg-7691

Conversation

@eric-gade
Copy link
Contributor

🎫 Ticket

LG-7691

🛠 Summary of changes

Updated the alert icon "badge" mode styling to have the correct position attribute, so pseudo-element displays in the correct position across browsers.

📜 Testing Plan

  • Clone, install, and run the local idp if you do not have a test instance to work from
  • Create and proof an account
  • Logout
  • At the login screen, select forgot password
  • Follow the steps and create a new password
  • At the profile screen, select reactivate your account
  • Select that you do have your personal key
  • The personal key re-entry screen you see here should be the one affected (see before and after screens below)

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before:

icon-before

After:

Screen Shot 2022-09-29 at 4 02 18 PM

🚀 Notes for Deployment

No special notes.

also updating transform so Edge can deal with it

changelog: Internal, Styling Updates, fixing icon positioning
@eric-gade eric-gade requested review from a team and akhlaqkhan September 29, 2022 20:14
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eric-gade eric-gade merged commit 0087afe into main Sep 30, 2022
@eric-gade eric-gade deleted the eric-lg-7691 branch September 30, 2022 15:08
@aduth aduth mentioned this pull request Oct 3, 2022
jskinne3 pushed a commit that referenced this pull request Oct 12, 2022
also updating transform so Edge can deal with it

changelog: Internal, Styling Updates, fixing icon positioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants