Merged
Conversation
changelog: Internal, Attempts API, Standardize events
n1zyy
approved these changes
Sep 30, 2022
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
Looks good! And kudos for improving tests as you go! 👏
Merged
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
changelog: Internal, Attempts API, Standardize events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
idv_phone_confirmation_otp_sent_rate_limitedevent as it duplicates functionality of another event.Since only one
idv_phone_otpevent contains the wordconfirmationnow, remove the wordconfirmationto standardize theidv_phone_otpevents (and seek to improve the associated unit tests).