Generate report in spec with the stubbed date#7072
Merged
Conversation
**Why**: The job uses the passed date for the reporting range, so it should correspond to the date used in stubbing data, like what's done in other test cases in the file. [skip changelog]
Merged
mitchellhenke
approved these changes
Oct 3, 2022
aduth
added a commit
that referenced
this pull request
Oct 3, 2022
**Why**: The job uses the passed date for the reporting range, so it should correspond to the date used in stubbing data, like what's done in other test cases in the file. [skip changelog]
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
**Why**: The job uses the passed date for the reporting range, so it should correspond to the date used in stubbing data, like what's done in other test cases in the file. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes build failures occurring for branches created after October 1 (new fiscal year). The job uses the passed date for the reporting range, so it should correspond to the date used in stubbing data, like what's done in other test cases in the file.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
rspec spec/jobs/reports/sp_active_users_report_spec.rb:14