LG-7620: Update IPP CTA language to include Baltimore option#7058
LG-7620: Update IPP CTA language to include Baltimore option#7058allthesignals merged 7 commits intomainfrom
Conversation
Includes updates to FR, ES, and EN locales.
allthesignals
force-pushed
the
wmg/7620-ipp-cta-updates
branch
from
3cd7431 to
c942b49
Compare
| troubleshooting: | ||
| headings: | ||
| are_you_near: 'Are you near Washington, D.C.?' | ||
| are_you_near: 'Are you located near Washington, D.C. <br/>or Baltimore, MD?' |
There was a problem hiding this comment.
Can we check if the line break element here may have some unintended impact on accessibility, such as a pause when reading? From what I recall, it may. We could consider adding an aria-hidden attribute to have it ignored by assistive technology. (This would need to be added as part of the formatHTML mapping, like in the example in the new documentation introduced with #7034).
There was a problem hiding this comment.
Good point, @aduth looping in @svalexander do you know what the effects might be? According to this answer <br/> means "read without pause."
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
|
For the current build failure, you may want to rebase your branch against the latest main, since the failure there was fixed in #7039. |
| troubleshooting: | ||
| headings: | ||
| are_you_near: 'Are you near Washington, D.C.?' | ||
| are_you_near: 'Are you located near Washington, D.C. <br/>or Baltimore, MD?' |
There was a problem hiding this comment.
Continuing the discussion from the previous thread, another reason for non-breaking spaces vs. explicit newlines can be to avoid situations where variations in screen size or locale can result in scenarios where a line break would need to occur before the explicit line break.
Example in French + iPhone SE:
This feels like a bit of an edge case so I'm not especially concerned about it in this instance, more that the general practice of trying to control line breaks like this can be more trouble than it's worth.
There was a problem hiding this comment.
Thanks, @aduth. I went ahead and merged, but I want to investigate this some more.
I'm not sure I'm following entirely, but it actually seems like we want some combination of a line break opportunity element and non-breaking spaces:
Are you located near Washington, D.C. <wbr/>or Baltimore, MD?
Something like this would occur:
I think this is a situation where my asking design their input on this would have helped a bit.
I'll open a follow-up PR
* Update IPP CTA language to include Baltimore option Includes updates to FR, ES, and EN locales. * Use formatHTML helper and br tag to generate newlines * changelog: Improvements, In-Person Proofing, Include new location in IPP CTA * Update README.md Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
2 participants
Update FR, ES, and EN IPP CTA language to include Baltimore option.
Ran these changes through
make normalize_yamlFollow up should include updates to: https://github.com/18F/identity-site/blob/20e3e81cd7ff94491f8709e4b1d2b52efd18bfa8/content/_help/verify-your-identity/verify-your-identity-in-person._en.md.
Note: This is a continuation of the now-closed PR.
🎫 Ticket
Link to the relevant ticket.
🛠 Summary of changes
Change IPP CTA language to include Baltimore, MD. Note the intentional newline after "or".
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: