LG-7187: Send Customer Experience Follow-up Email for In-Person Proofing by NavaTim · Pull Request #7046 · 18F/identity-idp

NavaTim · 2022-09-29T00:38:54Z

🎫 Ticket

LG-7187

🛠 Summary of changes

Send survey email to users after they:
- Pass in-person identity verification, and
- Share the verified information with the partner who requested the verification
Fix unreliable steps that interfered with automated survey email feature tests

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

Complete and pass the in-person proofing process through a partner
- For dev environments:
  - The partner can be 18F/identity-oidc-sinatra
  - You can use the Rails console to simulate passing IPP:
```
$ rails console
[1] pry(main)> enrollment = InPersonEnrollment.last
[2] pry(main)> enrollment.update(status: :passed)
[3] pry(main)> enrollment.profile.activate
```
Login using that partner in a manner that requires IAL2
Agree to share the IAL2 information with the partner
Check email for the survey

👀 Screenshots

Emails as they appear in Mailcatcher:

English:

Spanish:

French:

… test URL for survey

…ley/lg-7187-follow-up-survey-email

…ience Follow-up Email

…ley/lg-7187-follow-up-survey-email

app/controllers/sign_up/completions_controller.rb

aduth

Couple minor comments, but overall LGTM! 👍

app/models/user.rb

app/views/user_mailer/in_person_completion_survey.html.erb

aduth · 2022-09-29T17:58:30Z

spec/support/features/in_person_helper.rb

+    # Wait for page to load before selecting location
+    expect(page).to have_css('.location-collection-item')


Will have_css actually wait without a wait: parameter given, or will it assert against the current page?

According to the Capybara spec, has_css should wait for the content.

According to the Capybara spec, has_css should wait for the content.

Neat!

The default_max_wait_time shown in the test is set to 0.5 for 18F/identity-idp on local stacks and 5 in Gitlab CI.

aduth · 2022-09-29T18:03:29Z

spec/features/idv/in_person_spec.rb

+    [
+      :oidc,
+      :saml,
+    ].each do |service_provider|


Do you think there's value in exercising this for both SP protocols, or could we just do one? Reason I ask is that these tests can be quite slow to run.

I think it's valuable to have at least one IPP feature test covering both SP protocols, and to my knowledge this is the only one.

svalexander · 2022-09-29T19:39:52Z

app/controllers/sign_up/completions_controller.rb

    end
+
+    def send_in_person_completion_survey
+      return unless sp_session_ial == 2


what is the significance of 2 here?

This requires that the user be sharing attributes verified via IAL2 with the partner in order to trigger the survey email (as opposed to IAL1 or IAL3). Note that this current usage excludes the IAL "strict" mode.

This value is passed as an attribute from the partner. The value then gets mapped to the IAL constants (in a session value) during authentication.

…y email

app/services/idv/in_person/completion_survey_sender.rb

…ing (#7046) * LG-7187: Add follow-up survey field to in-person enrollments table * LG-7187: Start implementing email for follow-up survey * LG-7187: Style survey email and send on next partner sign-in * LG-7187: Send survey when user shares info with partner; add fallback test URL for survey * LG-7187: Test new survey DB query methods; format code * LG-7187: Expand tests; require IAL2 usage to send survey email * LG-7187: Add more tests relating to IPP survey email * LG-7187: Finish writing feature test for in-person proofing survey email * LG-7187: Fix unreliable tests and make IPP account creation reusable * changelog: Upcoming Features, In-person proofing, Send Customer Experience Follow-up Email * LG-7187: Add missing method to UserMailerPreview * LG-7187: Improve query tests; update English survey email translation * LG-7187: Combine paragraphs and use default margins/padding for survey email * LG-7187: Reference constant for IAL2 in IPP completion survey logic * LG-7187: Increase margin for paragraph above button

NavaTim added 12 commits September 21, 2022 16:36

LG-7187: Add follow-up survey field to in-person enrollments table

b72147a

LG-7187: Start implementing email for follow-up survey

44b903c

LG-7187: Style survey email and send on next partner sign-in

ed5d48c

LG-7187: Send survey when user shares info with partner; add fallback…

7ed9379

… test URL for survey

LG-7187: Test new survey DB query methods; format code

7e019a0

LG-7187: Expand tests; require IAL2 usage to send survey email

65e9a8f

Merge branch 'main' of https://github.com/18F/identity-idp into tbrad…

f00702a

…ley/lg-7187-follow-up-survey-email

LG-7187: Add more tests relating to IPP survey email

b648e0c

LG-7187: Finish writing feature test for in-person proofing survey email

f8cee4c

LG-7187: Fix unreliable tests and make IPP account creation reusable

9901546

changelog: Upcoming Features, In-person proofing, Send Customer Exper…

49ebd45

…ience Follow-up Email

Merge branch 'main' of https://github.com/18F/identity-idp into tbrad…

7e3a060

…ley/lg-7187-follow-up-survey-email

NavaTim requested review from a team, eileen-nava and rutvigupta-design and removed request for a team September 29, 2022 00:38

LG-7187: Add missing method to UserMailerPreview

ec79ee8

lizzieamanning reviewed Sep 29, 2022

View reviewed changes

app/controllers/sign_up/completions_controller.rb Show resolved Hide resolved

aduth approved these changes Sep 29, 2022

View reviewed changes

LG-7187: Improve query tests; update English survey email translation

2ddaecb

svalexander reviewed Sep 29, 2022

View reviewed changes

LG-7187: Combine paragraphs and use default margins/padding for surve…

09a5fd0

…y email

svalexander reviewed Sep 29, 2022

View reviewed changes

app/services/idv/in_person/completion_survey_sender.rb Show resolved Hide resolved

NavaTim added 2 commits September 29, 2022 13:13

LG-7187: Reference constant for IAL2 in IPP completion survey logic

9fc5791

LG-7187: Increase margin for paragraph above button

b5601ad

NavaTim merged commit f6dfc90 into main Sep 30, 2022

NavaTim deleted the tbradley/lg-7187-follow-up-survey-email branch September 30, 2022 17:07

aduth mentioned this pull request Oct 3, 2022

Deploy RC 214 to Prod #7071

Merged

aduth mentioned this pull request Oct 14, 2022

Fix flakey local test failures for in-person proofing feature specs #7145

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-7187: Send Customer Experience Follow-up Email for In-Person Proofing#7046

LG-7187: Send Customer Experience Follow-up Email for In-Person Proofing#7046
NavaTim merged 17 commits intomainfrom
tbradley/lg-7187-follow-up-survey-email

NavaTim commented Sep 29, 2022 •

edited

Loading

Uh oh!

Uh oh!

aduth left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduth Sep 29, 2022

Uh oh!

NavaTim Sep 29, 2022

Uh oh!

aduth Sep 29, 2022

Uh oh!

NavaTim Sep 29, 2022

Uh oh!

aduth Sep 29, 2022

Uh oh!

NavaTim Sep 29, 2022

Uh oh!

svalexander Sep 29, 2022

Uh oh!

NavaTim Sep 29, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		# Wait for page to load before selecting location
		expect(page).to have_css('.location-collection-item')

Conversation

NavaTim commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

👀 Screenshots

Uh oh!

Uh oh!

aduth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NavaTim commented Sep 29, 2022 •

edited

Loading