Lg 7265 - Inherited Proofing - Display user data on Please Verify page#7065
Lg 7265 - Inherited Proofing - Display user data on Please Verify page#7065holytoastr merged 5 commits intomainfrom
Conversation
Why: Inherited proofing users need to verify their data that has been imported is correct changelog: Internal, Inherited Proofing, User data on please verify page
holytoastr
added
the
inherited proofing
| <%# | ||
| locals: | ||
| pii - user's information | ||
| remote_identity_proofing - true if we're doing RIDP, false if we're doing IPP | ||
| step_url - generator for step URLs | ||
| %> |
There was a problem hiding this comment.
Can this be using the existing shared template, rather than duplicating it?
There was a problem hiding this comment.
There were enough differences between the two templates that I felt it would be better to use our own. (For at least the time being.) I would, ideally, like to move us to the existing shared one in the future but for MVP functionality this was the cleanest option.
There was a problem hiding this comment.
What are the differences? It looks like it may only be the titles, right? We could have a inheritted_proofing local or something like that to switch those. I think an even easier approach would be to check with @benjaminchait and @artfulaction if they are okay with using the titles from the existing "Verify your information" screen to keep things consistent.
There was a problem hiding this comment.
We're not allowing users to edit their addresses or ssn at this time, for example. I could put some conditionals in but it started to look really messy and I didn't want to 💩 up the shared template when I wasn't 100% sure we weren't going to restore editing later.
There was a problem hiding this comment.
This is an inconsistency/old version I didn't catch earlier, but yes, the title should read "Verify your information" instead of "Please verify your information". And yes, the addresses or SSN are not edited at this time, so I defer to y'all on whatever is easiest with the template.
There was a problem hiding this comment.
Another minor thing is the the user info should be displayed in all caps.
There was a problem hiding this comment.
@artfulaction Thanks for the careful eye! I have changed the title and put the user info in all caps. (The .upcase call is a quick fix until we get through MVP and can abstract that out of the view.)
There was a problem hiding this comment.
put the user info in all caps. (The .upcase call is a quick fix until we get through MVP and can abstract that out of the view.)
This seems fine, but going forward--I'd encourage us not to transform the data we get from the VA.
I believe IDV displays whatever is read from an identity document (eg. your name and address are passed to Login.gov in ALL CAPS) but if the VA passes data in Title Case, I'd encourage us to display it that way. (Since this is already merged, don't worry about changing it for now--but if/when we revisit, I'd encourage us to consider whether we should just display what we received from the wire.)
| <dt class="display-inline"> <%= t('idv.form.dob') %>: </dt> | ||
| <dd class="display-inline margin-left-0"> <%= pii[:dob] %> </dd> | ||
| </div> | ||
| <% if !remote_identity_proofing %> |
There was a problem hiding this comment.
If we're not going to use the existing template then why would we leave this in? This should never be a remote_identity_proofing context, right?
There was a problem hiding this comment.
Ah, I missed that one! Thank you, I thought I had caught them all
There was a problem hiding this comment.
Actually it looks like we set this to true which is even more confusing since we are doing remote proofing.
If we end up re-using the template I'd suggest renaming this var to something like should_display_state_id_number to describe what it actually does. If we don't re-use the template we can def get rid of the conditional here.
There was a problem hiding this comment.
Definitely a template that got a bit confusing on our end, especially with the things that were taken out for MVP
#7065) * Display user data on the please verify page (#7265) Why: Inherited proofing users need to verify their data that has been imported is correct changelog: Internal, Inherited Proofing, User data on please verify page * Clean up specs * Further clean up * Remove remote proofing check * Minor styling fixes - quick
5 participants
🎫 Ticket
LG 7265
🛠 Summary of changes
User data populates on the Inherited Proofing - Please Verify page
👀 Screenshots