Conversation
changelog: Bug Fixes, Identity Verification, Fix display of personal key page layout
aduth
commented
Sep 29, 2022
Comment on lines
-20
to
-27
| @include at-media('tablet') { | ||
| .separator-text > div { | ||
| &::after { | ||
| color: #000; | ||
| padding: 0 0.5rem; | ||
| } | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
As can be seen in the actual implementation, there are no <div> elements inside this element, so these styles were not doing anything and can be removed.
Merged
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Fix personal key block display changelog: Bug Fixes, Identity Verification, Fix display of personal key page layout * Fix padding-y at all viewport sizes * Remove unused key-badge styles * Update spec selectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This fixes an issue where the personal key page layout was malformed, as an unintended regression of #6986 due to accidental name collision of the
.separator-textclass added there.📜 Testing Plan
👀 Screenshots
Desktop:
Mobile: