Skip to content

LG-7640 review_status should be a top-level key#7048

Merged
stevegsa merged 4 commits intomainfrom
stevegsa-tmx-reviews-status-top-level
Sep 30, 2022
Merged

LG-7640 review_status should be a top-level key#7048
stevegsa merged 4 commits intomainfrom
stevegsa-tmx-reviews-status-top-level

Conversation

@stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Sep 29, 2022

🎫 Ticket

LG-7640

🛠 Summary of changes

Add the review status to the top level of the threatmetrix logging results for the following event:

"IdV: in person proofing optional verify_wait submitted"

from here:
properties.event_properties.proofing_results.context.stages.threatmetrix.response_body.review_status

to also here:
properties.event_properties.proofing_results.context.stages.threatmetrix.review_status

because cloudwatch has difficulty parsing large packets at depth

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Go through IDV flow and continue to just after 'verify your information'
  • Locally check the events.log for the event "IdV: in person proofing optional verify_wait submitted"
  • Verify that review_status is also at the top level of the json body for threatmetrix

👀 Screenshots

Screen Shot 2022-09-27 at 11 05 40 AM

🚀 Notes for Deployment

None

@stevegsa stevegsa marked this pull request as ready for review September 29, 2022 15:24
@stevegsa stevegsa requested a review from a team September 29, 2022 15:30
@stevegsa stevegsa requested a review from theabrad September 29, 2022 15:52
Copy link
Contributor

@theabrad theabrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevegsa stevegsa merged commit 89a9659 into main Sep 30, 2022
@stevegsa stevegsa deleted the stevegsa-tmx-reviews-status-top-level branch September 30, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants